Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: Update to Node.js 20 #425

Closed
wants to merge 3 commits into from
Closed

Chore: Update to Node.js 20 #425

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
81303f7
chore: update to Node.js 20
tuliomir Oct 25, 2023
1d55cad
fix: legacy ssl flag
tuliomir Dec 15, 2023
45ea265
feat: update to Node.js 20
tuliomir Jan 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/e2e.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ jobs:
runs-on: ubuntu-20.04
strategy:
matrix:
node-version: [14.x]
node-version: [20.x]
steps:
- name: Checkout
# https://github.com/actions/checkout/releases/tag/v4.0.0
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/main.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ jobs:
timeout-minutes: 40 # default is 360
strategy:
matrix:
node-version: [14.x]
node-version: [20.x]
steps:
# https://github.com/actions/checkout/releases/tag/v4.0.0
- uses: actions/checkout@3df4ab11eba7bda6032a0b82a6bb43b11571feac
Expand Down
2 changes: 1 addition & 1 deletion .nvmrc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
v14
v20
2 changes: 1 addition & 1 deletion ELECTRON.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
## Install

Must use node v14
Must use node v20 or greater

## Running on Electron

Expand Down
8 changes: 6 additions & 2 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,10 @@
"description": "Light wallet for Hathor Network",
"author": "Hathor Labs <[email protected]> (https://hathor.network/)",
"version": "0.27.1-rc3",
"engines": {
"node": ">=20.0.0",
"npm": ">=10.0.0"
},
"private": true,
"dependencies": {
"@hathor/wallet-lib": "1.0.4",
Expand Down Expand Up @@ -59,9 +63,9 @@
"scripts": {
"build-css": "sass --no-source-map src/index.scss src/index.css",
"watch-css": "npm run build-css && sass --no-source-map -w src/index.scss src/index.css",
"start-js": "react-scripts start",
"start-js": "react-scripts --openssl-legacy-provider start",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should map which dependencies need this --openssl-legacy-provider. So we know when we can remove this flag.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As described on the updated PR, the most relevant dependency for removing this flag is being discussed on #441

"start": "npm-run-all -p watch-css start-js",
"build-js": "react-scripts build",
"build-js": "react-scripts --openssl-legacy-provider build",
"build": "npm-run-all build-css build-js",
"test": "react-scripts test --env=./tests/env.js",
"e2e": "cypress run",
Expand Down