Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: eslint on both projects #156

Open
wants to merge 18 commits into
base: master
Choose a base branch
from
Open

refactor: eslint on both projects #156

wants to merge 18 commits into from

Conversation

andreabadesso
Copy link
Collaborator

…ervice's eslint

Motivation

What was the motivation for the changes in this PR?

Acceptance Criteria

  • Include here all things that this PR should solve

Checklist

  • If you are requesting a merge into master, confirm this code is production-ready and can be included in future releases as soon as it gets merged
  • Make sure either the unit tests and/or the QA tests are capable of testing the new features
  • Make sure you do not include new dependencies in the project unless strictly necessary and do not include dev-dependencies as production ones. More dependencies increase the possibility of one of them being hijacked and affecting us.

@andreabadesso
chore: added common package
408d995
@andreabadesso
chore: using wallet-lib from daemon resolution
2615a13
@andreabadesso
chore: installed shared dependencies on root project, using peerDepen…
e59b56c 
…dencies
@andreabadesso
refactor: using addAlert method from common utils
2b7093d
@andreabadesso
chore: updated package.json with missing deps
ed21c50
@andreabadesso
refactor: using types from commons on wallet-service
d6877ee
@andreabadesso
chore: re-added sequelize to root
fbfbbbf
@andreabadesso
refactor: removed isNftAutoReviewEnabled from services
37814ee
@andreabadesso
tests: mocked assertEnv
408a554
@andreabadesso
tests: mocked assertEnv on integration tests
e2e0849
@andreabadesso
chore: removed nft utils
ce00baf
@andreabadesso
refactor: removed old addAlerts from the wallet-service package
6a5d7fa
@andreabadesso
chore: wallet-lib is now a peerDependency in wallet-service package
81d2a6d
@andreabadesso
refactor: logger is now a required param in addAlert, refactored all …
28e23e3 
…methods in wallet-service package
@andreabadesso
docs: added missing hathor header
497f843
@andreabadesso
refactor: invalid type for metadata on addAlert
43f3af5
@andreabadesso
tests: passing mocked logger
8da7285
@andreabadesso
refactor: moved eslintrc to the correct packages and restore wallet-s…
2d33422 
…ervice's eslint
@andreabadesso andreabadesso mentioned this pull request Apr 5, 2024
Merged
3 tasks
@andreabadesso andreabadesso force-pushed the refactor/common-project branch from fe72085 to e4200a0 Compare April 5, 2024 15:25
@andreabadesso andreabadesso self-assigned this Apr 5, 2024
@andreabadesso andreabadesso added the enhancement New feature or request label Apr 5, 2024
@andreabadesso andreabadesso force-pushed the refactor/common-project branch 3 times, most recently from 9d84734 to 25261a1 Compare May 4, 2024 00:53
Base automatically changed from refactor/common-project to master May 30, 2024 00:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@andreabadesso andreabadesso

Labels
enhancement New feature or request
Projects
Hathor Network
Status: Todo
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@andreabadesso