feat: process txs as they arrive #810
Open
+145
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #810 +/- ##
==========================================
+ Coverage 80.68% 80.75% +0.07%
==========================================
Files 85 86 +1
Lines 6549 6594 +45
Branches 1419 1430 +11
==========================================
+ Hits 5284 5325 +41
- Misses 1252 1256 +4
Partials 13 13 ☔ View full report in Codecov by Sentry. |
Comment on lines
+1350
to
+1363
| if (metadataChanged) { | ||
| // Process the full history because | ||
| // this tx changed the voided state | ||
| // XXX in the future we should be able to handle this | ||
| // voidness alone, without processing everything | ||
| // but for now it's an isolated case and it's easier | ||
| await this.storage.processHistory(); | ||
| } else if (isNewTx) { | ||
| // Process this single transaction. | ||
| // Handling new metadatas and deleting utxos that are not available anymore | ||
| await this.storage.processNewTx(newTx); | ||
| } | ||
| // restore previous state | ||
| this.state = previousState; |
There was a problem hiding this comment.
Comment semi-related to line number
Code looks ok, but should we add tests for this new mechanism?
andreabadesso
approved these changes
Jan 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Nowadays we run the method to process the wallet full history every time a new tx arrives in the ws. Wallets with many transactions/addresses usually take a long time (0.5s) to process their entire history. There are cases where the wallet returns and error because of insufficient funds because it's processing the history of a recent transaction that has just arrived when the user wants to send a new tx.
Acceptance Criteria
Security Checklist