Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: improve websocket logs #412

Closed
wants to merge 30 commits into from
Closed

Conversation

luislhl
Copy link
Contributor

@luislhl luislhl commented Sep 14, 2022

Acceptance Criteria

  • Log when the websocket connection is established

Security Checklist

  • Make sure you do not include new dependencies in the project unless strictly necessary and do not include dev-dependencies as production ones. More dependencies increase the possibility of one of them being hijacked and affecting us.

@luislhl luislhl self-assigned this Sep 14, 2022
@codecov
Copy link

codecov bot commented Sep 14, 2022

Codecov Report

Merging #412 (fd07dcd) into dev (4dbbf57) will increase coverage by 0.00%.
The diff coverage is 50.00%.

@@           Coverage Diff           @@
##              dev     #412   +/-   ##
=======================================
  Coverage   56.68%   56.68%           
=======================================
  Files          55       55           
  Lines        4603     4604    +1     
  Branches      879      879           
=======================================
+ Hits         2609     2610    +1     
  Misses       1804     1804           
  Partials      190      190           
Impacted Files Coverage Δ
src/websocket/base.ts 82.69% <50.00%> (+0.16%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@luislhl
Copy link
Contributor Author

luislhl commented Sep 15, 2022

replaced by #416

@luislhl luislhl closed this Sep 15, 2022
@luislhl luislhl deleted the chore/improve-websocket-logs branch September 15, 2022 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants