Splitting up StateC and CompState #432
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Splitting StateC into a Reader/Writer/State transformer, as scadOpts was only ever read from, and messages was only ever written to or returned at the end of a processing batch. This also involved splitting these values out of CompState as they did not need to both readable and writable. Setting up some constraint types to allow easier use of the new monad transformer in code that doesn't need to know the exact structure of the transformer, just what it can do.
StateE has been split up along the same lines as StateC. ImplicitCadM has been fully parameterised so it can be used for StateE, allowing us to have a single transformer core stack for all of the reader/writer/state handling, dropping in types as needed. Changing most references to ImplicitCadM to StateC, as it is a type alias that has the expected types parameterised.
julialongtin
reviewed
Oct 8, 2022
Co-authored-by: Julia Longtin <[email protected]>
julialongtin
approved these changes
Oct 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Splitting StateC into a Reader/Writer/State transformer, as scadOpts was only ever read from, and messages was only ever written to or returned at the end of a processing batch.
This also involved splitting these values out of CompState as they did not need to both readable and writable.
Setting up some constraint types to allow easier use of the new monad transformer in code that doesn't need to know the exact structure of the transformer, just what it can do.