Reimplement R2 and R3 as V2 and V3 #342
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces
R2
andR3
withV2 R
andV3 R
respectively. There are some major benefits from this:both
,allthree
,CompontwiseMultiplable
, and in a follow-up PR,VectorStuff
.In addition, these vector types are well supported by the
linear
library, which in the future should allow us to simplify a good chunk of the math in this library and delegate it tolinear
.NOTE I expected this to be a no-op change, but it has caused three of the golden tests to fail. They are visible indistinguishable, but it's still a little disconcerting. I've looked through the diff three times and can't spot the culprit.
Fixes #286
Fixes #292