Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix getBox3 Rotate3 #303

Merged
merged 1 commit into from
Nov 21, 2020
Merged

Fix getBox3 Rotate3 #303

merged 1 commit into from
Nov 21, 2020

Conversation

sorki
Copy link
Contributor

@sorki sorki commented Nov 21, 2020

Without this

rotate3 (0, 0, 0) $ sphere 1

produces no geometry.

Related to #296.

(Please test, not quite sure about it).

FWIW the change was

-        rotate v1 w1 v2 w2 angle = getBox2(Rotate2 angle $ RectR 0 (v1, w1) (v2, w2))
+        rotate v1 w1 v2 w2 angle = getBox2(Rotate2 angle $ Translate2 (v2, w1) $ SquareR 0 (v2-v1, w2-w1))

@sorki
Fix getBox3 Rotate3
96d68e2 
Without this

```
rotate3 (0, 0, 0) $ sphere 1
```

produces no geometry.

Related to Haskell-Things#296.
@julialongtin
Copy link
Member

looks good to me.

@julialongtin julialongtin merged commit 41a8cd1 into Haskell-Things:master Nov 21, 2020
@isovector
Copy link
Contributor

Sorry about that!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sorki @julialongtin @isovector