Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Centralize Sorting #150

Merged
merged 47 commits into from
Jan 28, 2024
Merged
Changes from 1 commit
Commits
Show all changes
47 commits
Select commit Hold shift + click to select a range
f6d99c2
use sortPLinesByReference more.
julialongtin Jan 14, 2024
afd0275
play with concurrency in github.
julialongtin Jan 19, 2024
6567d7b
move from PL to DL (1 of 2)
julialongtin Jan 19, 2024
6cf663f
move from PL to DL (2 of 2)
julialongtin Jan 19, 2024
83b6c21
better error messages.
julialongtin Jan 20, 2024
384ebd0
add sortPLinesByReferenceSafe, and sortPLinesWithoutReference.
julialongtin Jan 20, 2024
62df4be
add tests for sortPLinesByReferenceSafe
julialongtin Jan 21, 2024
8c75cab
add more test cases, from our golden tests.
julialongtin Jan 21, 2024
8faba70
use safe version of sortPLinesByReference.
julialongtin Jan 21, 2024
ab18a19
fix sortPLinesByReferenceSafe, remove sortedPLines.
julialongtin Jan 27, 2024
1e12780
cleanup imports.
julialongtin Jan 27, 2024
17fcda1
remove unnecessary function.
julialongtin Jan 27, 2024
5a4c6d3
speedup.
julialongtin Jan 27, 2024
18680ab
make face logic use sortPLinesWithoutReference
julialongtin Jan 27, 2024
7fd3a2e
add a unit test for a failure condition we have since fixed.
julialongtin Jan 27, 2024
daa061b
add a test for an error condition we filter out.
julialongtin Jan 27, 2024
24d9217
better error messages, and use more normal variable names.
julialongtin Jan 27, 2024
5af80b6
make outAndErrOf inlinable.
julialongtin Jan 27, 2024
9c1a823
stop sorting iNodes twice.
julialongtin Jan 27, 2024
49c42f4
rename pLine1 to pLine.
julialongtin Jan 27, 2024
f7b5f3a
Improve error display, and optimize the interface of areaBetween and …
julialongtin Jan 28, 2024
a4f95e2
change the ordering of divisions, so that they are always in counter-…
julialongtin Jan 28, 2024
93ad96d
reorder some tests, and add the now working C5 inset and face tests.
julialongtin Jan 28, 2024
8682a31
try to get concurrency to work.
julialongtin Jan 28, 2024
98c39a1
give up on concurrency changes.
julialongtin Jan 28, 2024
53bd45e
add ghc 9.6.4 to our matrix.
julialongtin Jan 28, 2024
de67892
add remove ghc 8.8.
julialongtin Jan 28, 2024
36df30a
remove ghc 9.6.
julialongtin Jan 28, 2024
1f2c917
update dependencies of ormolu.
julialongtin Jan 28, 2024
3b5ac5c
attempt to ormolu smarter.
julialongtin Jan 28, 2024
94cd235
be more specific about cabal version.
julialongtin Jan 28, 2024
49366e4
drop GHC version.
julialongtin Jan 28, 2024
3862401
stop trying to freeze for ormolu.
julialongtin Jan 28, 2024
2a0c88a
bump ormolu version.
julialongtin Jan 28, 2024
bc74fa5
bump ghc version for ormolu.
julialongtin Jan 28, 2024
7f955ce
re-add freezing.
julialongtin Jan 28, 2024
77b3227
only run CI on pushes.
julialongtin Jan 28, 2024
c129748
break CI into three stages: build, test, and haddock.
julialongtin Jan 28, 2024
d4b4253
break CI into three stages: build, test, and haddock.
julialongtin Jan 28, 2024
11bdd6b
smarter caching usage?
julialongtin Jan 28, 2024
45f67b6
continue being more specific about cacheing.
julialongtin Jan 28, 2024
4de3e74
continue being more specific about cacheing.
julialongtin Jan 28, 2024
c918db9
continue being more specific about cacheing.
julialongtin Jan 28, 2024
5c20d28
continue being more specific about cacheing.
julialongtin Jan 28, 2024
9dc726c
cache more directories.
julialongtin Jan 28, 2024
9bc1f04
caching working!
julialongtin Jan 28, 2024
a4971fd
cache more, in case of upstream changes mid-build
julialongtin Jan 28, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
continue being more specific about cacheing.
  • Loading branch information
julialongtin committed Jan 28, 2024
commit 5c20d2815c857797c8717b88076f54e43a00b2b8
8 changes: 4 additions & 4 deletions .github/workflows/ci.yaml
Original file line number Diff line number Diff line change
@@ -22,18 +22,18 @@ jobs:
fi
- name: freeze
run: cabal freeze
- uses: "actions/cache/restore@v4"
- name: Restore build artifacts
id: build-hslice-restore
uses: "actions/cache/restore@v4"
with:
key: "${{ runner.os }}-${{ matrix.ghc }}-cabal-${{ hashFiles('cabal.project.freeze') }}"
path: "${{ steps.setup-haskell-cabal.outputs.cabal-store }} dist-newstyle"
- name: Install dependencies
run: cabal build all --enable-tests --enable-benchmarks --only-dependencies
- name: build all
run: cabal build all --enable-tests --enable-benchmarks
- uses: "actions/cache/save@v4"
- name: Save build artifacts
uses: "actions/cache/save@v4"
with:
key: "${{ runner.os }}-${{ matrix.ghc }}-cabal-${{ hashFiles('cabal.project.freeze') }}"
path: "${{ steps.setup-haskell-cabal.outputs.cabal-store }} dist-newstyle"
@@ -66,8 +66,8 @@ jobs:
fi
- name: freeze
run: cabal freeze
- uses: "actions/cache/restore@v4"
- name: Restore build artifacts
uses: "actions/cache/restore@v4"
id: build-hslice-restore
with:
key: "${{ runner.os }}-${{ matrix.ghc }}-cabal-${{ hashFiles('cabal.project.freeze') }}"
@@ -76,8 +76,8 @@ jobs:
run: cabal build all --enable-tests --enable-benchmarks --only-dependencies
- name: build all
run: cabal build all --enable-tests --enable-benchmarks
- uses: "actions/cache/save@v4"
- name: Save build artifacts
uses: "actions/cache/save@v4"
with:
key: "${{ runner.os }}-${{ matrix.ghc }}-cabal-${{ hashFiles('cabal.project.freeze') }}"
path: "${{ steps.setup-haskell-cabal.outputs.cabal-store }} dist-newstyle"
Loading