Use NonEmpty for arrays that specify minItems > 0 #102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pbrisbin
changed the title
This comment was marked as resolved.
This comment was marked as resolved.
|
Thank you a lot for this PR! Good catch regarding the example code! I have not used/updated this in a long while as I use the golden tests more regularly. Especially for showing the change in the code generation, this would be the place to do it. Could you update the PR to change Once this is cleaned up, I am happy to merge this PR! |
|
Done and done. Thanks for the continued quick engagement! |
joel-bach
merged commit 9476e37
into
Haskell-OpenAPI-Code-Generator:master
9 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use NonEmpty for arrays that specify minItems > 0
a89d27d
Exercise minItems/NonEmpty in golden tests
325816a