Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for devcontainers #110

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

rishabkumar7
Copy link

@rishabkumar7 rishabkumar7 commented Mar 26, 2024

Devcontainer let's you use a container as a full-featured development environment. It allows you to open any folder inside (or mounted into) a container and take advantage of Visual Studio Code's full feature set. GitHub Codespaces also utilises this file.

Configure the devcontainer.json to install all the dependencies and export port 3000.
Here is a GitHub Codespaces example:
image

Copy link

vercel bot commented Mar 26, 2024

@rishabkumar7 is attempting to deploy a commit to the Hashnode Team on Vercel.

A member of the Team first needs to authorize it.

@Harsh062
Copy link
Contributor

Hi @rishabkumar7,

Thank you for your contribution and for adding devcontainer support to our open-source blog starter kit! This is a valuable addition to our project.

However, we've encountered an issue with the image specified in the devcontainer.json file: mcr.microsoft.com/devcontainers/universal:2. This image is not compatible with ARM64 architectures, such as those used by Apple’s M1/M2 Macs. Consequently, users on these systems will face errors when attempting to set up the development environment. There is also an issue reported on Github regarding this here

To ensure broader compatibility across different systems, including ARM64, we recommend switching to an image that supports buster or bullseye tags, which are more universally compatible. Here is a suggestion that could be a good alternative:
mcr.microsoft.com/devcontainers/javascript-node:0-18-bullseye
We recommend testing this image to ensure it meets the requirements of our project.

By making this change, we can ensure that our devcontainer setup is accessible to a wider range of developers and systems.
Looking forward to your updated PR!

Best regards,
Harsh

@Harsh062
Copy link
Contributor

Hi @rishabkumar7,
I hope you're doing well.
I wanted to follow up on the above suggestion and was wondering if you had a chance to review the proposed changes.
Looking forward to your response.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants