-
Notifications
You must be signed in to change notification settings - Fork 674
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Presale whitelisting using maps #27
base: main
Are you sure you want to change the base?
Conversation
Exactly the same as Hashlips does in his video
…Sent from my iPhone
On 24 Jan 2022, at 7:53 am, jaydeebow ***@***.***> wrote:
how the heck do I verify this? I've tried multi-file and flat. remix never gives me the option to copy the constructor arguments after deploy. I've tried hashex. Nothing works.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications on the go with GitHub Mobile for iOS or Android.
You are receiving this because you authored the thread.
|
I see what you mean now.
That is because the original contract from hashlips did not provide
constructor override functionality like his other contracts.
Murf.
…On Mon, 24 Jan 2022 at 09:07, jaydeebow ***@***.***> wrote:
load it up on remix and try to deploy. you will see what i mean. I doesn't
make you set the arguments when deploying. so I cant verify because I have
no tx data to copy.
—
Reply to this email directly, view it on GitHub
<#27 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAG72OKRSFMTDP7NQ4V6US3UXSC25ANCNFSM5MBQ4BHQ>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Will this be merged soon? Would like to try this out |
@liarco I was wondering if you have any input into this implementation or feedback as well of whitelisting using mapping to retain gas fee efficiency throughout the mint loop. |
Hi @DEXExchange, thank you for reaching out to us. In my opinion implementing whitelists by managing the addresses one by one always leads to poor gas efficiency. We (@HashLips and I) are working on something new to be released soon that allows everyone to manage whitelists without any back end (full on-chain solution) and being able to change from 1 to hundreds of addresses in the list with just a few bucks in gas fees. Please stay tuned for that, it will be huge! 😉 |
Hey @liarco Are you guys working on a Merkle tree approach? I am implementing a merkle approach myself I thought if you are already working on it, I might as well wait for a bit and discard my work if the timing allows it 😎 If that's the case do you have any ETA for a release? |
Hi @laygir, I'm really happy to hear that you are working on this kind of solution. First answer is: yes! But we are not gonna stop with a basic Merkle Tree implementation on the contract side, we are gonna provide the whole community with really cool tools to manage the whole stuff. Can't say too much at the moment because we are still picking the best features that we think are ready for the first release, but I'm pretty sure you are gonna love it! 😃 As far as the ETA, can't really give it for sure (testing and doing fine-tuning takes it's time), but I hope it's not gonna take long... maybe 2 weeks at most? 🤐 |
OMG I'm so happy to hear this. I really hope it only takes about 2 weeks. 🤞🤞 Can we also get something like firebase for metamask authentication so you can only connect to the dapp if your address is on our db. |
I have implemented this contract build based off the SimpleNFTLowerGas contract with @Murf whitelist map commit: https://github.com/DEXExchange/ERC721-NFT-OptmizedGas-WhitelistMapping/blob/main/BAACGenesis.sol May I kindly ask your input/criticisms in any capacity about if this contract build with mapping is sufficient for gas efficiency retention due to the whitelist parameters? I did place reentrancy guard as well into the contract. Any input i greatly appreciate to learn from. Best regards, -KinToshiGG (I look forward to learning from your Merkle Tree implementations and utilities, as I have been often hearing about this approach to better gas efficiency retention during presale whitelist events.) |
Hi @DEXExchange, I may be wrong, but there are a few things that I would probably handle differently from the solution you are sharing here. Even gas efficiency, in example, can be very subjective here... I think you can get a more efficient implementation with small tweaks (at least from the buyer side), but the problem I see is that this solution can be a nightmare for the owner. The management cost for this solution can be an issue even before you start thinking about the minting cost. Code complexity is also another possible issue. The Those are just the first things that came to my mind looking at the code, but unfortunately I don't have time to get deep in each line at the moment... and with Solidity each single line really matters in terms of gas efficiency. I strongly suggest waiting for the upcoming solution so maybe we can run some benchmarks. |
I greatly appreciate your feedbacks. Thank you. |
hello guys! was curious as to when the contract with Merkle tree (i think that is what you are implementing) is coming out! I have been working on implementing it and have been stuck for quite some time now and something to compare to would be amazing! you guys are awesome! hopefully i can be of some help and contribute when i am more proficient! |
Hi @andrewzourob, we are almost there and I can finally say that the new project is going to be released next week. :) It's going to be announced on HashLips' YouTube channel. |
Awesome news!! Will this be the Merkle Tree on the new low gas contract or on the original contract? |
The new solution is going to combine all the features from the lower gas contract plus the new stuff, all in one single package. 😉 |
wohoooo thank you! :) |
@liarco thank you so much :) |
Hi Liarco! Saw Hashlips just dropped a video. Is that the all in on solution you were referring to? Can that contract be used efficiently for the collection drop or shall I still wait for a different release? |
Yes, it is: https://www.youtube.com/watch?v=ynZzPNkS1nk 😃 More videos are coming since there are many features to show. |
Amazing! Thanks so much going to follow that video step by step! So that Merkle Tree method that is implemented, do you know about how much each address will cost to add? I know the old method was expensive so just want to be sure before offering X amount of whitelist spots and getting a huge bill lol |
Would you like it if I tell you that it costs the same no matter the size of your list? 😊 |
Oh my goodness that's amazing! lol I was contemplating doing 250 WL spots because it was going to cost too much, now I can do even more! And in that repo all the Merkle code is complete so we just have to add addresses after deploy! This also completely takes out the Remix way, correct? |
You can never use remix again, but I'm gonna make a video about how to use it anyway, for all the people that prefer not to input their private keys into the |
Sweet! Please share your YouTube as well would love to check it out! Thanks again for all your help! |
Thank you, here it is: https://www.youtube.com/channel/UCsNUSP49XDIhxaZoZlLwnyw |
just subbed ✌️ |
@liarco |
Hi @stevenbenmoha, my reference is always the ethereum network, so you have to make some proportion for other networks depending on their prices. :) |
Hi Liarco, sorry to keep bugging you here. Last question, in the previous low gas contract the owner was able to mint while the contract was paused to allow us to get the necessary NFTs for our marketing/us. Is this still an option on the new version or what would be the best way for the owner to mint their say 100 NFTs from the collection? |
@Skellyfish the new contract is directly based on the LowerGas one, so you should find all the same features in it, as well as the |
I am eagerly waiting for that. When are you going to release the video and on which channel ? |
Hi @dhararughani, the video will be released on my youtube channel. I already started publishing some content about the tool but there are many topics to cover so it will take me some time to record all the stuff, but stay tuned! 😉 |
This is a better way of implementing a pre-sale whitelist using maps.
Also has a function to add an array into the list.