Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implementing eip-2981 for royalties #63

Open
Ahmeddh opened this issue Apr 22, 2022 · 5 comments
Open

Implementing eip-2981 for royalties #63

Ahmeddh opened this issue Apr 22, 2022 · 5 comments

Comments

@Ahmeddh
Copy link

Ahmeddh commented Apr 22, 2022

Hello there

if you read about eip-2981, it allows the contract to signal the royalty fees to marketplaces, its not yet supported by opensea, but other marketplaces like looksrare, superrare and rariple do support it

I know you may see that OS is the leader and the one with the most volume, but missing the royalty fees usually happens with other marketplaces that sometimes the contract creator has no clue that his collection is being sold there.

I'll try to implement it in the low gas contract and push it for @HashLips for review, but implementation from the man himself gives it more credibility with the community IMO

Thanks for reading

@0xJonHoldsCrypto
Copy link

0xJonHoldsCrypto commented Apr 22, 2022 via email

@Ahmeddh
Copy link
Author

Ahmeddh commented Apr 22, 2022

Wonderful is there a way to test this on a testnet, hence opensea is not yet compatible with eip-2981 and they don't send royalties on their rinkeby testnet anyway

@0xJonHoldsCrypto
Copy link

0xJonHoldsCrypto commented Apr 22, 2022 via email

@Ahmeddh
Copy link
Author

Ahmeddh commented Apr 23, 2022

Does rarible send royalties on testnet and are compatible with eip-2981?

@netcinematics
Copy link

@0xJonHoldsCrypto did this get implemented? Or is 2981 abandoned now?
What is concensus on Royalties at the moment? Thx. : )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants