Added NQueens in Java #1531
Merged
Added NQueens in Java #1531
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HarshCasper
requested changes
Dec 16, 2020
Java/cp/NQueens.java
Outdated
| Scanner scn = new Scanner(System.in); | ||
| int n = scn.nextInt(); | ||
| boolean[][] board = new boolean[n][n]; | ||
| //write your code here |
There was a problem hiding this comment.
This Comment is redundant. If you are solving a CP Problem from an Online Portal, prefer to add the link as well.
| return; | ||
| } | ||
|
|
||
| for(int col=0; col<board.length; col++) { |
There was a problem hiding this comment.
Can you put apt comments on your Code for better explainability?
| @@ -0,0 +1,61 @@ | |||
| /** | |||
| N-Queens problem is a famous problem | |||
There was a problem hiding this comment.
If possible, please add further information about the Algorithm
|
@HarshCasper changes done !! |
HarshCasper
requested changes
Dec 21, 2020
Java/cp/NQueens.java
Outdated
| Space Complexity : O(n^2) | ||
| Time Complexity : upperbounded by O(n^n) | ||
|
|
||
| **/ |
| rdiag[row-col+board.length-1] = true; | ||
| board[row][col] = true; | ||
| solve(board, cols, ndiag, rdiag, row+1, asf+row+'-'+col+", "); | ||
| // backtrack |
There was a problem hiding this comment.
Can you make the comments more understandable?
| for(int col=0; col<board.length; col++) { | ||
| if(cols[col] == false && ndiag[row+col] == false && | ||
| rdiag[row-col+board.length-1] == false) { | ||
| // place the queen |
There was a problem hiding this comment.
Can you make the comments more understandable?
|
@HarshCasper changes done !! |
HarshCasper
approved these changes
Dec 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Have you read the Contributing Guidelines on Pull Requests?
(Yes)
Description
(NQueens added in Java)
Checklist
README.mdand link to my code.Related Issues or Pull Requests
(Issue #1524 is solved here)