Sidhant prs #1518
Merged
Sidhant prs #1518
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pr is related to the issue - Dutch National Flag Implementation #1462 |
|
Hello @Sidhant-Gupta If you are picking problems for CP/DS-Algo Portals, please add their link. The above problem is from a LeetCode Problem. |
|
I've made the desired changes. Please review it. |
HarshCasper
requested changes
Dec 21, 2020
Comment on lines
3
to
25
| // | ||
| // PROBLEM STATEMENT- https://leetcode.com/problems/sort-colors/ | ||
|
|
||
| // Given an array nums with n objects colored red, white, or blue, sort them in-place so that objects of the same color are adjacent, with the colors in the order red, white, and blue. | ||
| // Here, we will use the integers 0, 1, and 2 to represent the color red, white, and blue respectively. | ||
| // In simpler words sort an array containing 0,1,2. | ||
|
|
||
| // Solve the problem with a one-pass algorithm using only O(1) constant space? | ||
|
|
||
| // TEST CASE- | ||
| // Input: | ||
| // n=6 | ||
| // nums = [2,0,2,1,1,0] | ||
| // Output: [0,0,1,1,2,2] | ||
|
|
||
| // Input: | ||
| // n=3 | ||
| // nums = [2,0,1] | ||
| // Output: [0,1,2] | ||
|
|
||
| // The bruteforce approach - Sort the vector in nlogn time | ||
|
|
||
| // ************************DUTCH_NATIONAL_FLAG ALGORITHM*********************************** |
There was a problem hiding this comment.
Shift the Comments above any lines of code
Comment on lines
12
to
21
| // TEST CASE- | ||
| // Input: | ||
| // n=6 | ||
| // nums = [2,0,2,1,1,0] | ||
| // Output: [0,0,1,1,2,2] | ||
|
|
||
| // Input: | ||
| // n=3 | ||
| // nums = [2,0,1] | ||
| // Output: [0,1,2] |
There was a problem hiding this comment.
Shift the sample I/O after the Code ends
| med++; | ||
| } | ||
| else{ | ||
| // swap(nums[med],nums[high]); |
There was a problem hiding this comment.
Remove any instances of commented lines of code. We prefer to have comments over the code but not commented code
|
|
||
| // COMPLEXITY ANALYSIS- | ||
| // Time= O(N) | ||
| // space=O(1) |
|
I've made all the requested changes. Kindly review @HarshCasper |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Have you read the [Contributing Guidelines on Pull Requests]
Yes,I have read.
(Write your answer here.)
Description
Dutch National Flag Algorithm- Implemented in C++.
Checklist
Related Issues or Pull Requests
(Write your answer here.)