Boyer Moore’s Voting Algorithm in C++ #1442
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
December 10, 2020 16:27
This is my First Contribution to NeoAlgo, as a part of WoC.
|
@iamrajiv The logo was also in this branch, sorry about that, ill take care next time, could you check that too? |
iamrajiv
suggested changes
Dec 11, 2020
|
Okay sure |
|
@iamrajiv Kindly review it now. |
|
Done. |
iamrajiv
suggested changes
Dec 11, 2020
added 2 commits
December 11, 2020 16:48
|
Sorry didn't know what to do, did it now. |
iamrajiv
suggested changes
Dec 11, 2020
There was a problem hiding this comment.
Your code is similar to this https://www.geeksforgeeks.org/majority-element/.
|
But I wrote this a while ago for a competition at my college |
|
I will rewrite this and submit another pull request |
iamrajiv
suggested changes
Dec 11, 2020
There was a problem hiding this comment.
Again your code is similar to this https://www.techiedelight.com/find-majority-element-in-an-array-boyer-moore-majority-vote-algorithm/.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-->
Have you read the Contributing Guidelines on Pull Requests?
Yes
Description
This is my first pull request as my contribution to WoC.
Boyer Moore’s Voting Algorithm in C++
Checklist
README.mdand link to my code.Related Issues or Pull Requests
Its the solution to Boyer Moore’s Voting Algorithm in C++