Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Linear Search Algorithm #12

Closed
HarshCasper opened this issue Jun 25, 2020 · 13 comments
Closed

Add Linear Search Algorithm #12

HarshCasper opened this issue Jun 25, 2020 · 13 comments
Assignees
Labels
easy enhancement New feature or request good first issue Good for newcomers

Comments

@HarshCasper
Copy link
Owner

HarshCasper commented Jun 25, 2020

Algorithm:

Linear Search

DS:

  • Searching

Languages Missing:

@HarshCasper HarshCasper added documentation Improvements or additions to documentation enhancement New feature or request good first issue Good for newcomers C C-Plus-Plus easy JavaScript Python and removed documentation Improvements or additions to documentation labels Jun 25, 2020
@github-actions
Copy link

Hi! Thanks for creating an issue. Please make sure to check the guidelines before creating an issue :)

@UtkarshChaurasia
Copy link
Contributor

UtkarshChaurasia commented Jun 25, 2020

Can I work on this for the languages C++, JAVA and Python?

@HarshCasper
Copy link
Owner Author

HarshCasper commented Jun 25, 2020

I have assigned you the Issue. You can start working on it @UtkarshChaurasia

The Code for Java has already been added. You can work with C++ and Python instead.

Please follow the general guidelines:

  • Make a Branch off your Master and work on that.
  • Make a proper README of how your Script works and what all libraries and modules you have used.
  • Add Proper Comments and focus on Clean Code, in practice.
  • Also reference this Issue in your PR so that it becomes easy for us to review.

@guri76148
Copy link

can i work in javascript?

@omonimus1
Copy link
Contributor

omonimus1 commented Jun 25, 2020

Hi to everyone.
I have created a pull request for this issue, adding the implementation of the Linear search algorithms in JavaScripts (will all the tests).
You can easily test all the source code in a few seconds on jsfiddle.

The tests run from the pipeline do not pass, can I get any advice about the type of checks done on every pull request? :)

I would like to fix the pull request ASAP and do it properly.
Thank you :)

omonimus1 added a commit to omonimus1/NeoAlgo that referenced this issue Jun 26, 2020
@sparkingdark
Copy link
Contributor

I want to work it on C @HarshCasper

@HarshCasper
Copy link
Owner Author

I have assigned you the Issue @sparkingdark

@sparkingdark
Copy link
Contributor

Thanks ready to work

HarshCasper added a commit that referenced this issue Jun 26, 2020
ISSUE #12, Adds Linear search algorithm implemented using JavaScript
This was referenced Jun 26, 2020
@UtkarshChaurasia UtkarshChaurasia removed their assignment Jun 26, 2020
@MSufiyanAG
Copy link
Contributor

@ricardoprins i would like to work on this in java . and i completed #13 please merge it its pr is #138 .

@HarshCasper
Copy link
Owner Author

I have assigned you the Issue. You can start working on it @MSufiyanAG 💥

@HarshCasper HarshCasper removed the Java label Jun 27, 2020
ricardoprins pushed a commit that referenced this issue Jun 29, 2020
@atarax665
Copy link
Contributor

@ricardoprins This issue needs to be closed.

@HarshCasper
Copy link
Owner Author

@all-contributors please add @bagladivyang03 for code

@allcontributors
Copy link
Contributor

@HarshCasper

I've put up a pull request to add @bagladivyang03! 🎉

iamrajiv pushed a commit that referenced this issue Dec 10, 2020
HarshCasper pushed a commit that referenced this issue Dec 29, 2020
Added solution to Staircase Problem in Readme issue #1455
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
easy enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

8 participants