Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENHANCEMENT] Algorithms in Go Lang - folder structure #11

Closed
KamalDGRT opened this issue Jun 25, 2020 · 12 comments
Closed

[ENHANCEMENT] Algorithms in Go Lang - folder structure #11

KamalDGRT opened this issue Jun 25, 2020 · 12 comments
Assignees
Labels
enhancement New feature or request question Further information is requested

Comments

@KamalDGRT
Copy link

Implementing the algorithms in Go Language would be a plus.

@KamalDGRT KamalDGRT added the enhancement New feature or request label Jun 25, 2020
@github-actions
Copy link

Hi! Thanks for creating an issue. Please make sure to check the guidelines before creating an issue :)

@ricardoprins ricardoprins added the question Further information is requested label Jun 25, 2020
@ricardoprins
Copy link
Contributor

Hi @KamalDGRT !

The algorithms can be implemented by anyone who has knowledge in the language :)

I have unassigned us in this post, so that any collaborator who desires to fork the repo, create the folder and implement the algorithms can do it.

I appreciate the great suggestion!

@KamalDGRT
Copy link
Author

Thank you @ricardoprins

@Sanketwable
Copy link

I want to work on this

@KamalDGRT
Copy link
Author

KamalDGRT commented Jun 28, 2020

Me too.
And I think it is best to store the code for each algorithm of go language in a separate folder.
This is because, when 2 .go files are in the same folder, the execution of the same will result in error.

@Sanketwable
Copy link

Sanketwable commented Jun 28, 2020

That's a good idea. I was thinking of generating different packages for each algo. And can be accessed by the single main package. So there will be no error generated and everyone will be able to access the packages by importing github.com/TesseractCoding/NeoAlgo/"Folder-Name".

@ricardoprins
Copy link
Contributor

Makes sense to me!

@Sanketwable
Copy link

Please assign this issue so that I can start contributing.

@ricardoprins
Copy link
Contributor

awesome! let's do it!

@ricardoprins
Copy link
Contributor

Alright, before we go ahead, we need to discuss a few things.

If we add a "one-folder-per-code" model, we'd end up with a reasonably complex structure...
However, if we keep just the "one folder per topic" model, we'll need that every person looking for code understands that they'd be browsing the repo for code only, and that they'll need to place the code within the proper structure in their own execution environment...

Which of the two models will we choose?

Since I'm at this moment running a bot to create a basic folder structure for the whole repository, I'll be sticking temporarily to the second model until we make a decision here.

I am also renaming the issue to make the topic clearer.

@ricardoprins ricardoprins changed the title Algorithms in Go Lang [ENHANCEMENT] Algorithms in Go Lang - folder structure Jun 30, 2020
@Sanketwable
Copy link

"one-folder-per-topic" will be preferred by me because it will also help users import packages. As I mentioned before.
#11 (comment)

I also prefer the second model.

@ricardoprins
Copy link
Contributor

I believe this is outdated. Closing now.

iamrajiv pushed a commit that referenced this issue Dec 10, 2020
HarshCasper pushed a commit that referenced this issue Dec 29, 2020
Added the solution for Count ways to N'th Stair. issue #1455
sakinanomi pushed a commit to sakinanomi/NeoAlgo that referenced this issue May 9, 2021
* feat: Added Docs

* Fixed URL

* Fixed Broken Links config

* Adding Team Members

* Added more

* Added past maintainer details and some doc

* Added more

* Added NeoAlgo Blogs

* Final Changes

* Added layouts and more

* Added Anush
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request question Further information is requested
Projects
None yet
Development

No branches or pull requests

6 participants