Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use async keyboard report sending in matrix scanning #199

Merged
merged 1 commit into from
Dec 18, 2024

Conversation

HaoboGu
Copy link
Owner

@HaoboGu HaoboGu commented Dec 17, 2024

Now the matrix scanning result is sent key processor using try_send, which might result in missing key event when typing fast. Changing to async send might slow down the scanning rate when the channel is full, but no more missing key.

Copy link

PR build size

  text	   data	    bss	    dec	    hex	filename
120352	    116	  41308	 161776	  277f0	rmk-nrf52840

Diff

    FILE SIZE        VM SIZE    
 --------------  -------------- 
  +0.8% +9.57Ki  [ = ]       0    .debug_str
  +0.5% +3.99Ki  [ = ]       0    .debug_info
  +2.1% +3.85Ki  [ = ]       0    .debug_loc
  +0.6%    +592  [ = ]       0    .debug_ranges
  +0.3%    +260  +0.3%    +260    .text
  +0.2%    +215  [ = ]       0    .debug_line
  +0.1%     +32  [ = ]       0    .symtab
  +0.1%     +12  [ = ]       0    .debug_frame
  -0.2%      -1  [ = ]       0    .defmt
 -10.9%      -7  [ = ]       0    [Unmapped]
  -0.0%      -8  [ = ]       0    .debug_aranges
  -0.1%    -112  [ = ]       0    .strtab
  +0.7% +18.4Ki  +0.2%    +260    TOTAL

@HaoboGu HaoboGu merged commit 4d24faf into main Dec 18, 2024
23 checks passed
@HaoboGu HaoboGu deleted the fix/matrix_scanning branch December 19, 2024 07:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant