Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Direct Pin matrix for split keyboards. #140

Merged
merged 3 commits into from
Dec 5, 2024

Conversation

DivineGod
Copy link
Contributor

@DivineGod DivineGod commented Nov 11, 2024

  • Update config to handle Matrix for split firmware
  • Implement direct_pin support in split central run function
  • Implement direct_pin support in split peripheral run function
  • Add peripheral examples
  • Add central examples
  • Update split config examples
  • Add non-config example
  • Update relevant documentation

@DivineGod DivineGod force-pushed the feat/split-direct-pin branch 2 times, most recently from 16efd8d to 4a7e5fe Compare November 14, 2024 05:37
@DivineGod
Copy link
Contributor Author

I've tested the updated examples and confirmed that it does indeed work as expected.

I'm not entirely sure the col2row feature is integrated correctly with all the changes, as the config for direct_pins seem a bit unintuitive to me. But that might just be me missing something.

@HaoboGu
Copy link
Owner

HaoboGu commented Dec 3, 2024

@DivineGod Hey, do you have any plan making this PR merged? Since most parts of the PR has been finished, getting it merged should can be very quick.

@DivineGod
Copy link
Contributor Author

Yes, I do. I will rebase to make sure it'll merge well and look at updating all the relevant places in documentation now.

* Update config to handle Matrix for split firmware

implement peripheral direct pin

implement central split direct pin run function
@DivineGod DivineGod force-pushed the feat/split-direct-pin branch from c06caeb to 6c1df65 Compare December 3, 2024 03:51
@DivineGod DivineGod marked this pull request as ready for review December 3, 2024 04:01
@DivineGod
Copy link
Contributor Author

I have added documentation about using the config to setup direct pin matrix splits.

I've chosen not to document the rust way since it might be a bit confusing and I haven't tested it fully myself yet

@HaoboGu
Copy link
Owner

HaoboGu commented Dec 5, 2024

I'm merging it. Thanks A LOT!

@HaoboGu HaoboGu merged commit af56233 into HaoboGu:main Dec 5, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants