We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Y
Hello, multiple DateTimeFormatter patterns in this repository use Y. However, that is 'week-based-year'. Maybe they should rather use y ('year-of-era')? This makes a difference near the end of some years where y is still the current year, but Y is already the next year. See for example https://errorprone.info/bugpattern/MisusedWeekYear or https://rules.sonarsource.com/java/type/Bug/RSPEC-3986 for details.
DateTimeFormatter
y
Affected:
tilesfx/src/main/java/eu/hansolo/tilesfx/skins/CalendarTileSkin.java
Line 58 in 578b579
tilesfx/src/main/java/eu/hansolo/tilesfx/skins/ClockTileSkin.java
Line 66 in 578b579
Line 193 in 578b579
tilesfx/src/main/java/eu/hansolo/tilesfx/skins/DateTileSkin.java
Line 36 in 578b579
tilesfx/src/main/java/eu/hansolo/tilesfx/skins/TimelineTileSkin.java
Line 100 in 578b579
DTF
D
tilesfx/src/main/java/eu/hansolo/tilesfx/tools/Helper.java
Line 617 in 578b579
Line 619 in 578b579
Line 621 in 578b579
getY()
The text was updated successfully, but these errors were encountered:
Fix for issue #158
2371ae0
No branches or pull requests
Hello,
multiple
DateTimeFormatter
patterns in this repository useY
. However, that is 'week-based-year'. Maybe they should rather usey
('year-of-era')?This makes a difference near the end of some years where
y
is still the current year, butY
is already the next year. See for example https://errorprone.info/bugpattern/MisusedWeekYear or https://rules.sonarsource.com/java/type/Bug/RSPEC-3986 for details.Affected:
tilesfx/src/main/java/eu/hansolo/tilesfx/skins/CalendarTileSkin.java
Line 58 in 578b579
tilesfx/src/main/java/eu/hansolo/tilesfx/skins/ClockTileSkin.java
Line 66 in 578b579
tilesfx/src/main/java/eu/hansolo/tilesfx/skins/ClockTileSkin.java
Line 193 in 578b579
tilesfx/src/main/java/eu/hansolo/tilesfx/skins/DateTileSkin.java
Line 36 in 578b579
tilesfx/src/main/java/eu/hansolo/tilesfx/skins/TimelineTileSkin.java
Line 100 in 578b579
This
DTF
pattern also looks a bit weird; why include 'day of month' (not 'day of year',D
) and 'year' but not 'month'? Is that intended?tilesfx/src/main/java/eu/hansolo/tilesfx/tools/Helper.java
Line 617 in 578b579
tilesfx/src/main/java/eu/hansolo/tilesfx/tools/Helper.java
Line 619 in 578b579
tilesfx/src/main/java/eu/hansolo/tilesfx/tools/Helper.java
Line 621 in 578b579
Important: This pattern also accidentally got corrupted by fb06ab6; it contains
getY()
The text was updated successfully, but these errors were encountered: