Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for Stream Deck Mini V2 #3378

Merged
merged 3 commits into from
Feb 16, 2023

Conversation

latenitefilms
Copy link
Contributor

- Currently untested. Uses same code as Stream Deck Mini, just changing the product ID.
- Closes Hammerspoon#3377
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull request does not contain a valid label. Please add one of the following labels: ['pr-fix', 'pr-change', 'pr-feature', 'pr-maintenance']

@latenitefilms
Copy link
Contributor Author

@Badsheep - Are you able to build Hammerspoon locally to test this out?

@cmsj
Copy link
Member

cmsj commented Feb 9, 2023

@latenitefilms we could just initialise the existing Mini class, if there's no actual changes required?

@github-actions
Copy link

github-actions bot commented Feb 9, 2023

View Test Results

348 tests   295 ✔️  1h 3m 3s ⏱️
    2 suites    52 💤
    1 files        1

For more details on these failures, see this check.

Results for commit b6dbfa4.

♻️ This comment has been updated with latest results.

@latenitefilms
Copy link
Contributor Author

@cmsj - Yes, I reckon we probably can, however, I went with this way for now, as I'm thinking they've probably changed how it works to be more like the other newer models, so I'm anticipating we might need to tweak some things. I haven't had a chance to do some Googling to see how other open source libraries handle these newer devices yet.

@Badsheep
Copy link

Badsheep commented Feb 9, 2023

@Badsheep - Are you able to build Hammerspoon locally to test this out?

No I’m sorry

@latenitefilms
Copy link
Contributor Author

This isn't signed or notarised, so you might have to right-click to open, but give this a shot:

Hammerspoon.zip

@Badsheep
Copy link

Badsheep commented Feb 9, 2023

This isn't signed or notarised, so you might have to right-click to open, but give this a shot:

Hammerspoon.zip

Sorry it doesn't seems to open :
Capture d’écran 2023-02-09 à 08 00 54

@Badsheep
Copy link

Badsheep commented Feb 9, 2023

If I right click, open the Hammerspoon app directly, I have :

Capture d’écran 2023-02-09 à 08 01 33

@latenitefilms
Copy link
Contributor Author

Ah, apologies, I must have only built it for Apple Silicon.

@Badsheep
Copy link

Badsheep commented Feb 9, 2023

Yes I own a intel-based MBP

@Badsheep
Copy link

Hello, I did test on my girlfriend's Silicon Macbook : it works.
Of course I haven't tested all the API functions and methods... only hs.streamdeck:setButtonImage(button, image), which seems to work.

Of course I'd be very interested in a Intel built so I can work on my computer ;)
Thanks you very much !

@latenitefilms
Copy link
Contributor Author

Try this one:

Hammerspoon.zip

@Badsheep
Copy link

Yes it works :)
Thank you !

@latenitefilms
Copy link
Contributor Author

Awesome! Can you try this one. It's exactly the same, but I've removed the HSStreamDeckDeviceMiniV2 files, and we're just using the HSStreamDeckDeviceMini files as @cmsj suggested.

Hammerspoon 2.zip

@Badsheep
Copy link

OK, it seems to work too !

@cmsj
Copy link
Member

cmsj commented Feb 11, 2023

Nice!
@latenitefilms the diff for this PR still has the V2 .m/.h files showing up in the project file, otherwise I'm happy for this to merge.

@latenitefilms
Copy link
Contributor Author

@cmsj - My bad, I deliberately didn't push changes to the Xcode project, as I had to make some other tweaks to make it build for Intel machines. Fixed!

@cmsj cmsj merged commit 6d83452 into Hammerspoon:master Feb 16, 2023
@cmsj cmsj added the pr-feature Pull Request implementing a feature label Mar 12, 2023
@Badsheep
Copy link

Badsheep commented Apr 7, 2023

Hello,

Sorry to come back on this case !
But I may have found a bug on the latest release (0.9.100) ? Or maybe it' been introduced before, I don't really know.

When I run the test version you gave two months ago (in the post above), everything works.

But when I install the last version (0.9.100), the first button (on the top and on the left) doesn't works anymore.
That's the only one not working... the other I use are working.

But it's not completely broke : in my configuration, the image of the button changes depending on the status of the fonction (ON or OFF). And with the new version, the Stream Deck Mini RECEIVES the status (and the images changes correctly), but when I press the button it doesn't change On/Off...

(I hope I'm clear).

@latenitefilms
Copy link
Contributor Author

That's very strange. I'm away for a couple of weeks, but will try and reproduce when I'm back in the office.

@Badsheep
Copy link

Badsheep commented Apr 8, 2023

Yes it's strange.
I can send you my .hammerspoon configuration if it helps to debug.

@Badsheep
Copy link

Badsheep commented Apr 8, 2023

If you want I can also try all the versions between the one you made for me and the actual, and tell you at which version the bug is introduced.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-feature Pull Request implementing a feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for latest Stream Deck Mini (20GAI9902)
3 participants