Speed up window switching timers #3237
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmsj
requested changes
Jul 1, 2022
| @@ -224,11 +224,11 @@ local function exit(self) | |||
| -- if windows[selected]:application():bundleID()~='com.apple.finder' then | |||
| -- windows[selected]:focus() | |||
| -- else | |||
| timer.doAfter(0.15,function()windows[selected]:focus()end) -- el cap bugs out (desktop "floats" on top) if done directly | |||
| timer.doAfter(0.01,function()windows[selected]:focus()end) -- el cap bugs out (desktop "floats" on top) if done directly | |||
There was a problem hiding this comment.
FWIW El Capitan is no longer supported by Hammerspoon, so we could see what happens if we remove the timer.doAfter() wrapper and just directly call windows[selected]:focus()
There was a problem hiding this comment.
I just tested. Directly calling it seems to work well for me. Should I change it?
There was a problem hiding this comment.
Apologies for not replying - yeah I think we should change it.
There was a problem hiding this comment.
Ok, I just committed the change
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
El Capitan is no longer supported by Hammerspoon, so we no longer need the timer delay workaround.
stickler-ci
reviewed
Nov 3, 2022
| @@ -224,11 +224,11 @@ local function exit(self) | |||
| -- if windows[selected]:application():bundleID()~='com.apple.finder' then | |||
| -- windows[selected]:focus() | |||
| -- else | |||
| timer.doAfter(0.15,function()windows[selected]:focus()end) -- el cap bugs out (desktop "floats" on top) if done directly | |||
| function()windows[selected]:focus() | |||
There was a problem hiding this comment.
(E011) expected identifier near '('
cmsj
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Window switching with hs.window.switcher is noticeably slower than the default cmd-tab. This small patch decreases various timers to make the speed feel the same. Note: I decreased a timer that's supposed to prevent an el cap bug, but I couldn't test if this reintroduces the el cap issue.