Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed crash in hs.image.getExifFromPath() #3177

Merged
merged 3 commits into from
Apr 23, 2022
Merged

Fixed crash in hs.image.getExifFromPath() #3177

merged 3 commits into from
Apr 23, 2022

Conversation

latenitefilms
Copy link
Contributor

github-actions[bot]
github-actions bot requested changes Apr 2, 2022
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull request does not contain a valid label. Please add one of the following labels: pr-fix, pr-change, pr-feature, pr-maintenance

@cmsj cmsj added the pr-fix Pull Request implementing a bug fix label Apr 2, 2022
@cmsj
Copy link
Member

cmsj commented Apr 2, 2022

lgtm, although I now wonder what happens if you pass it a URL to a file that either doesn't exist, or isn't an image?

@latenitefilms
Copy link
Contributor Author

I tested passing in random text and it just returned nil, didn't try a valid path to a non-image, but I THINK if should return nil too - will test.

@latenitefilms latenitefilms mentioned this pull request Apr 3, 2022
Closed
@github-actions
Copy link

github-actions bot commented Apr 3, 2022

View Test Results

0 files  0 suites   0s ⏱️
0 tests 0 ✔️ 0 💤 0 ❌

Results for commit 59186f9.

@cmsj cmsj merged commit f12ce9d into Hammerspoon:master Apr 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stickler-ci stickler-ci stickler-ci left review comments

@github-actions github-actions[bot] github-actions[bot] approved these changes

Assignees
No one assigned
Labels
pr-fix Pull Request implementing a bug fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Crash - hs.image.getExifFromPath()
3 participants
@latenitefilms @cmsj @stickler-ci