Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

0.9.96 breaks hs.menubar icon alignment #3171

Closed
luckman212 opened this issue Mar 29, 2022 · 3 comments
Closed

0.9.96 breaks hs.menubar icon alignment #3171

luckman212 opened this issue Mar 29, 2022 · 3 comments
Labels
bug
Milestone
0.9.97

Comments

@luckman212
Copy link
Contributor

repro:

foo = hs.menubar.new()
foo:setIcon(hs.image.imageFromName('NSTouchBarCommunicationAudioTemplate'))
foo:setTitle('fooBar')

result

note the overlap, icon should be positioned to the left of the title

image
cmsj added a commit that referenced this issue Mar 29, 2022
@cmsj
Fix default hs.menubar image positioning, and add hs.menubar:imagePos…
30f6ddd 
…ition(). Closes #3171
@cmsj
Copy link
Member

cmsj commented Mar 29, 2022

Thanks @luckman212. I've prepared a PR which I will merge shortly, that fixes this, and as a bonus, also exposes a new hs.menubar:imagePosition() which can be used to show the image before/after the text (or overlap for some reason)

@cmsj cmsj added the bug label Mar 29, 2022
@cmsj cmsj added this to the 0.9.97 milestone Mar 29, 2022
@cmsj cmsj closed this as completed in 019d376 Mar 29, 2022
@cmsj
Copy link
Member

cmsj commented Mar 29, 2022

A signed dev build with the fix, will appear here soon: https://github.com/Hammerspoon/hammerspoon/actions/runs/2061369499

@luckman212
Copy link
Contributor Author

I grabbed the test build - works great! thanks @cmsj

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
0.9.97
Development

No branches or pull requests
2 participants
@cmsj @luckman212