Ensure native sockets are closed appropriately in hs.ping. Closes #3387…

… (#3419)
Hammerspoon · Mar 11, 2023 · 3ca0cb9 · 3ca0cb9
1 parent 86a4479
commit 3ca0cb9
Showing 1 changed file with 8 additions and 0 deletions.
diff --git a/extensions/network/ping/SimplePing.m b/extensions/network/ping/SimplePing.m
@@ -764,7 +764,15 @@ - (void)stopHostResolution {
 
 - (void)stopSocket {
     if (self.socket != NULL) {
+        int fd = CFSocketGetNative(self.socket);
+
+        if (CFSocketGetSocketFlags(self.socket) & kCFSocketCloseOnInvalidate) {
+            fd = -1; // No need to manually close the socket, it'll happen automatically
+        }
         CFSocketInvalidate(self.socket);
+        if (fd != -1) {
+            close(fd);
+        }
         self.socket = NULL;
     }
 }