-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#171644111 - Resume playback #133
base: develop
Are you sure you want to change the base?
Conversation
Is there a URL where I can have a look at this? |
This works nicely. Good work. Couple of things:
|
Re 1, I did look into this and MDN suggests that the user agent manages this:
Re 2, good idea, seems easy enough so I'll take a look as part of this PR. |
I was thinking more along the lines of is it performant to call |
08046c5
to
4b1945f
Compare
I found mixed things on how resource intensive it actually is, but agree that it's overkill to do so frequently. I've added an interval with 4b1945f which updates localstorage once per second. I've updated the preview too: https://dev.video.hammer.cogapp.com |
a8ce7bd
to
a6f0fc7
Compare
PT: #171644111 - Resume playback