Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check for hosts in nextsubnet. Fixes #23 #24

Merged
merged 2 commits into from
Feb 16, 2024
Merged

Conversation

kd7lxl
Copy link
Member

@kd7lxl kd7lxl commented Jun 2, 2020

Demo:

(env)tom@Baldi-SRV1:~/src/hamwanadmin$ ./manage.py nextsubnet point-to-point 30
https://encrypted.hamwan.org/admin/portal/subnet/add/?network=44.25.8.16/30
44.25.8.16/30

(env)tom@Baldi-SRV1:~/src/hamwanadmin$ ./manage.py nextsubnet point-to-point 30 --ignore-hosts
https://encrypted.hamwan.org/admin/portal/subnet/add/?network=44.25.8.0/30
44.25.8.0/30

(env)tom@Baldi-SRV1:~/src/hamwanadmin$ ./manage.py nextsubnet --help
Usage: ./manage.py nextsubnet [options] <block name> <prefix length>

Prints the next available subnet in the specified block.

Suggested block names:
    New space
    End-user DHCP and direct allocations
    Infrastructure
    Loopback
    Anycast
    OPP
    Point-to-Point
    HamWAN Open Peering Policy client gateway addresses
    Loopback interfaces
    Anycast
Block names use case-insensitive starts-with matching.

Options:
  -v VERBOSITY, --verbosity=VERBOSITY
                        Verbosity level; 0=minimal output, 1=normal output,
                        2=verbose output, 3=very verbose output
  --settings=SETTINGS   The Python path to a settings module, e.g.
                        "myproject.settings.main". If this isn't provided, the
                        DJANGO_SETTINGS_MODULE environment variable will be
                        used.
  --pythonpath=PYTHONPATH
                        A directory to add to the Python path, e.g.
                        "/home/djangoprojects/myproject".
  --traceback           Raise on exception
  --ignore-hosts        Skips checking for any hosts in the new subnet
  --version             show program's version number and exit
  -h, --help            show this help message and exit

@kd7lxl kd7lxl requested a review from bkus-goog June 2, 2020 19:44
@kd7lxl kd7lxl force-pushed the hosts-in-subnet branch from 44a60e0 to 44be9ab Compare June 2, 2020 19:54
@turnrye
Copy link

turnrye commented Sep 9, 2020

@kd7lxl I know via e-mail you mentioned wanting to see CI running the tests, but it looks like 3 months ago you already added this. So congrats, future you, because past you helped you out!

@kd7lxl kd7lxl requested review from bkus and removed request for bkus-goog December 31, 2022 01:40
@dpkingston dpkingston self-requested a review February 16, 2024 23:41
Copy link
Member

@dpkingston dpkingston left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. And we have been running on this for some time without issue. This is a post push approval in large part to clean up the pull request backlog.

@dpkingston dpkingston merged commit 6c808b4 into master Feb 16, 2024
1 check passed
@dpkingston dpkingston deleted the hosts-in-subnet branch February 16, 2024 23:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants