[core] Fixed static variable usage in the crypto module. #3047
+24
−26
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As reported in #3035,
srt/haicrypt/hcrypt_xpt_srt.c
has two definitions of the static variable_hcMsg_SRT_MsgInfo
:One more problem is the
.parseMsg
field off the structure that is initialized with a pointer tohcryptMsg_SRT_ParseMsg
function. ThehcryptMsg_SRT_ParseMsg
function in its turn uses the static _hcMsg_SRT_MsgInfo internally.To resolve this interdependency the
hcryptMsg_SRT_ParseMsg
function is made visible and now requires a pointer to ahcrypt_MsgInfo
structure instead of using the static variable implicitly.The
_hcMsg_SRT_MsgInfo
can now be const and initialized once the following way:Fixes #3035.