Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python 2 fixes + insert size distribution #46

Merged
merged 6 commits into from
Feb 8, 2018
Merged

Python 2 fixes + insert size distribution #46

merged 6 commits into from
Feb 8, 2018

Conversation

HadrienG
Copy link
Owner

@HadrienG HadrienG commented Feb 3, 2018

This PR addresses the bugs from #45 (and more):

Python2 related:

  • zip(*args.ncbi, *args.n_genomes) not supported. Changed syntax.
  • changed import httpto import http.client to catch the incomplete download/N exceptions
  • insertions are str and not unicode anymore

Not python2 related:

  • iss does not skip a genome if its length is shorter than the random insert size drawn from the model. Produces a random insert size within acceptable limits instead.

@codecov
Copy link

codecov bot commented Feb 3, 2018

Codecov Report

Merging #46 into master will increase coverage by 0.71%.
The diff coverage is 87.87%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #46      +/-   ##
==========================================
+ Coverage   73.97%   74.69%   +0.71%     
==========================================
  Files          19       19              
  Lines        1122     1142      +20     
==========================================
+ Hits          830      853      +23     
+ Misses        292      289       -3
Impacted Files Coverage Δ
iss/app.py 0% <0%> (ø) ⬆️
iss/download.py 0% <0%> (ø) ⬆️
iss/test/test_generator.py 100% <100%> (ø) ⬆️
iss/generator.py 92.79% <100%> (+5.05%) ⬆️
iss/error_models/__init__.py 79.76% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ff8bd27...1bdd8a8. Read the comment docs.

@HadrienG HadrienG merged commit 62e29d2 into master Feb 8, 2018
@HadrienG HadrienG deleted the py2 branch December 12, 2018 07:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant