Changed author tag to author_name #223
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes a bug in the plugin we use to generate RSS feeds. Long story short, the plugin extracts the
authorfield from the page metadata. However as mentioned here, the RSS spec expects this to include an email address. This is sub-optimal because we don't want to force people to provide that. Additionally there is no way to turn this off in the plugin.To get around this I've changed the
authorfield toauthor_name. To facilitate this, I've modified our contributing docs to ensure there is a new template, modified ouroverridesto expect this new name, and gone through all the pages in the site and updated this.While this is an inelegant solution, it solves the problem quickly and ensures we will have RSS support, which is a win :)