Install with setuptools aka pip #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will install all the needed pip packages and the software packages. Also allows for versions to trigger updates if ran with tools like Ansible, Puppet, ect.
|
|
||
| ## Running | ||
| To run the application run the following command in this folder | ||
| > python smartmirror.py |
There was a problem hiding this comment.
I think this is the appropriate place to ask users where they'd like the weather/news from. Modifying scripts is a bit tedious in my opinion.
There was a problem hiding this comment.
Its up to @atainter, I do like not editing config files and run everything from CLI. Perhaps someone could add something like this.
pyhton smartmirror.py --token TOKEN_KEY
There was a problem hiding this comment.
I think pyhton smartmirror.py --token TOKEN_KEY would be tedious if you have to append the token every time you run it. Let's keep it as is for now.
ewized
changed the title
|
LGTM. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the ability to install the smart mirror with one command.
This also makes the readme clear on what to do.
The following command will work once merged.
To test this run the following command to trigger from my repo.