Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implementation of 24h clock, other language and unit #13

Merged
merged 3 commits into from
Oct 12, 2016

Conversation

smileyn64
Copy link
Contributor

Good evening,
I implemented:

  • 24h clock
  • other language and unit pulled from weather forecast
  • locale module thread proof for international date conversion

@atainter
Copy link
Contributor

Are all of your dependencies included with python 2.7?

@smileyn64
Copy link
Contributor Author

I double checked and yes they are.
Also made some test by launching with Python 2.7, seems working like a charm.

@smileyn64
Copy link
Contributor Author

for info, I let the variables independent for maximizing the personalization of the program.
e.g. I'm french, living in Indonesia, so like to have the UI in french but clock in 12h format, the US news and the weather of indonesia.

by the way I just added the AM/PM to the clock when the format is 12h.

@atainter
Copy link
Contributor

LG. Nice work

@atainter atainter merged commit 2737991 into HackerShackOfficial:master Oct 12, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants