Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: UI issue in custom time input #4197

Closed

Conversation

navedqb
Copy link
Contributor

@navedqb navedqb commented Aug 10, 2023

Fixes #4185.

Copy link

@pullrequest pullrequest bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ This pull request was sent to the PullRequest network.


@navedqb you can click here to see the review status or cancel the code review job.

Copy link

@pullrequest pullrequest bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PullRequest Breakdown

Reviewable lines of change

+ 2
- 2

100% SCSS

Type of change

Fix - These changes are likely to be fixing a bug or issue.

@codecov
Copy link

codecov bot commented Aug 10, 2023

Codecov Report

Merging #4197 (a3ba026) into main (d0d9c57) will not change coverage.
Report is 8 commits behind head on main.
The diff coverage is n/a.

❗ Current head a3ba026 differs from pull request most recent head 0612ed3. Consider uploading reports for the commit 0612ed3 to get more accurate results

@@           Coverage Diff           @@
##             main    #4197   +/-   ##
=======================================
  Coverage   93.64%   93.64%           
=======================================
  Files          20       20           
  Lines        1904     1904           
  Branches      464      464           
=======================================
  Hits         1783     1783           
  Misses         44       44           
  Partials       77       77           

Copy link

@pullrequest pullrequest bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR adjusts some CSS to fix a display issue (unfortunately, the PR description doesn't provide me too many more details).

Image of Morgan M Morgan M


Reviewed with ❤️ by PullRequest

src/stylesheets/datepicker.scss Outdated Show resolved Hide resolved
Copy link

@pullrequest pullrequest bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like some pretty easy margin adjustments. I'm unable to visually verify.

Image of Steven S Steven S


Reviewed with ❤️ by PullRequest

Copy link

@pullrequest pullrequest bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Due to inactivity, PullRequest has cancelled this review job. You can reactivate the code review job from the PullRequest dashboard.

@martijnrusschen
Copy link
Member

Can you post a before/after of this fix?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

showTimeInput now has a visual issue
2 participants