Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed/Module not found: Can't resolve 'react-onclickoutside' #4122 #4196

Merged
merged 1 commit into from
Aug 10, 2023

Conversation

gyananshu07
Copy link
Contributor

fixed/Module not found: Can't resolve 'react-onclickoutside' #4122

A dependency react-onclickoutside was missing.

Copy link

@pullrequest pullrequest bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ This pull request was sent to the PullRequest network.


@gyananshu07 you can click here to see the review status or cancel the code review job.

Copy link

@pullrequest pullrequest bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PullRequest Breakdown

Reviewable lines of change

+ 1
- 1

100% JSON

Generated lines of change

+ 1
- 1

Type of change

Fix - These changes are likely to be fixing a bug or issue.

Copy link

@pullrequest pullrequest bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change is looking fine to me, bumping the minimum version of react-onclickoutside.

Image of Graham C Graham C


Reviewed with ❤️ by PullRequest

@martijnrusschen
Copy link
Member

Not sure why this should solve the issue you're referring to, but bumping the version is fine.

@codecov
Copy link

codecov bot commented Aug 10, 2023

Codecov Report

Merging #4196 (25eb905) into main (d0d9c57) will not change coverage.
The diff coverage is n/a.

❗ Current head 25eb905 differs from pull request most recent head e1892dc. Consider uploading reports for the commit e1892dc to get more accurate results

@@           Coverage Diff           @@
##             main    #4196   +/-   ##
=======================================
  Coverage   93.64%   93.64%           
=======================================
  Files          20       20           
  Lines        1904     1904           
  Branches      464      464           
=======================================
  Hits         1783     1783           
  Misses         44       44           
  Partials       77       77           

Copy link

@pullrequest pullrequest bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PullRequest reviewed the updates made to #4196 since our last review was posted. This includes comments that have been posted by non-PullRequest reviewers. No further issues were found.

Reviewed by:

Image of Graham C Graham C

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants