-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fixed/Module not found: Can't resolve 'react-onclickoutside' #4122 #4196
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✅ This pull request was sent to the PullRequest network.
@gyananshu07 you can click here to see the review status or cancel the code review job.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PullRequest Breakdown
Reviewable lines of change
+ 1
- 1
100% JSON
Generated lines of change
+ 1
- 1
Type of change
Fix - These changes are likely to be fixing a bug or issue.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change is looking fine to me, bumping the minimum version of react-onclickoutside
.
Reviewed with ❤️ by PullRequest
Not sure why this should solve the issue you're referring to, but bumping the version is fine. |
Codecov Report
@@ Coverage Diff @@
## main #4196 +/- ##
=======================================
Coverage 93.64% 93.64%
=======================================
Files 20 20
Lines 1904 1904
Branches 464 464
=======================================
Hits 1783 1783
Misses 44 44
Partials 77 77 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PullRequest reviewed the updates made to #4196 since our last review was posted. This includes comments that have been posted by non-PullRequest reviewers. No further issues were found.
Reviewed by:
fixed/Module not found: Can't resolve 'react-onclickoutside' #4122
A dependency react-onclickoutside was missing.