Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update usage of findDOMNode #4190

Merged
merged 19 commits into from
Oct 9, 2023
Merged

Update usage of findDOMNode #4190

merged 19 commits into from
Oct 9, 2023

Conversation

martijnrusschen
Copy link
Member

@martijnrusschen martijnrusschen commented Aug 7, 2023

Description:
This pull request addresses an issue where the use of ReactDOM.findDOMNode was causing compatibility problems in certain scenarios. To resolve this, we have updated the code to use findDOMNode directly.

Changes Made:

  • Replaced instances of ReactDOM.findDOMNode with findDOMNode throughout the codebase.
  • This change ensures improved compatibility with the latest React versions and eliminates potential issues related to the deprecated ReactDOM.findDOMNode method.

Copy link

@pullrequest pullrequest bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ This pull request was not sent to the PullRequest network because the title contains "draft:".

@codecov
Copy link

codecov bot commented Aug 7, 2023

Codecov Report

Merging #4190 (21f1d81) into main (8b28bb7) will not change coverage.
The diff coverage is n/a.

❗ Current head 21f1d81 differs from pull request most recent head fc64949. Consider uploading reports for the commit fc64949 to get more accurate results

@@           Coverage Diff           @@
##             main    #4190   +/-   ##
=======================================
  Coverage   96.54%   96.54%           
=======================================
  Files          27       27           
  Lines        2374     2374           
  Branches      966      966           
=======================================
  Hits         2292     2292           
  Misses         82       82           

@martijnrusschen martijnrusschen changed the title draft: Update findDOMNode Update usage of findDOMNode Oct 9, 2023
Copy link

@pullrequest pullrequest bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ This pull request was sent to the PullRequest network.


Check the status or cancel PullRequest code review here.

Copy link

@pullrequest pullrequest bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PullRequest Breakdown

Reviewable lines of change

+ 114
- 113

100% JavaScript (tests)

Type of change

Feature - These changes are adding a new feature or improvement to existing code.
1 Message
It looks like the description for this pull request is either blank or very short. Adding a high-level summary will help our reviewers provide better feedback. Feel free to include questions for PullRequest reviewers and make specific feedback requests.

Copy link
Contributor

@Zarthus Zarthus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes seem harmless and LGTM, the CI seems happy too :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants