-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update usage of findDOMNode #4190
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Codecov Report
@@ Coverage Diff @@
## main #4190 +/- ##
=======================================
Coverage 96.54% 96.54%
=======================================
Files 27 27
Lines 2374 2374
Branches 966 966
=======================================
Hits 2292 2292
Misses 82 82 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✅ This pull request was sent to the PullRequest network.
Check the status or cancel PullRequest code review here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PullRequest Breakdown
Reviewable lines of change
+ 114
- 113
100% JavaScript (tests)
Type of change
Feature - These changes are adding a new feature or improvement to existing code.
1 Message | |
---|---|
✅ |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes seem harmless and LGTM, the CI seems happy too :)
Description:
This pull request addresses an issue where the use of
ReactDOM.findDOMNode
was causing compatibility problems in certain scenarios. To resolve this, we have updated the code to usefindDOMNode
directly.Changes Made:
ReactDOM.findDOMNode
withfindDOMNode
throughout the codebase.ReactDOM.findDOMNode
method.