fix: always show date select

[kelatev]

[gihan9a]

Please merge this ASAP. We are seeing this unexpected selected date on UI

[codecov]

Codecov Report

Merging #3948 (15c1350) into master (8a8cb7d) will decrease coverage by 0.13%.
The diff coverage is 96.50%.

❗ Current head 15c1350 differs from pull request most recent head 7b7b54f. Consider uploading reports for the commit 7b7b54f to get more accurate results

@@            Coverage Diff             @@
##           master    #3948      +/-   ##
==========================================
- Coverage   94.09%   93.96%   -0.13%     
==========================================
  Files          20       20              
  Lines        1726     1890     +164     
  Branches      419      458      +39     
==========================================
+ Hits         1624     1776     +152     
- Misses         31       40       +9     
- Partials       71       74       +3     

Impacted Files	Coverage Δ
src/tab_loop.jsx	60.00% <ø> (+2.10%)	⬆️
src/day.jsx	93.43% <60.00%> (-1.27%)	⬇️
src/calendar.jsx	94.09% <93.33%> (-0.10%)	⬇️
src/month.jsx	93.81% <95.50%> (+1.17%)	⬆️
src/date_utils.js	99.21% <100.00%> (+0.08%)	⬆️
src/index.jsx	88.85% <100.00%> (-1.28%)	⬇️
src/week_number.jsx	77.77% <100.00%> (-9.73%)	⬇️
src/year.jsx	97.47% <100.00%> (+0.29%)	⬆️

[martijnrusschen]

Can you provide more information on the change?

[kelatev]

1. I added new prop showDateSelect. When this prop is append (for example: <DatePicker showDateSelect selected={utils.newDate()} />), block .react-datepicker__aria-live is showing "Selected date"
2. I fixed block .react-datepicker__aria-live when they empty they not showing full (not only hide content)

[martijnrusschen]

Why are we adding this behind a prop?

[kelatev]

this.setState({ isRenderAriaLiveMessage: true }); run in func handleSelect without check for need to renderAriaLiveMessage
Any change date on datepicker run handleSelect and always set isRenderAriaLiveMessage: true

This code fix that. set isRenderAriaLiveMessage: true only if developer set prop showDateSelect

[pullrequest]

✅ This pull request was sent to the PullRequest network.

---

@kelatev you can click here to see the review status or cancel the code review job.

[pullrequest]

PullRequest Breakdown

Reviewable lines of change

+ 9
- 5

71% JavaScript
29% JavaScript (tests)

Type of change

Fix - These changes are likely to be fixing a bug or issue.

[pullrequest]

Nice work here. I have just one concern left inline as a reply to another comment.

Graham C

---

Reviewed with ❤️ by PullRequest

[pullrequest]

PullRequest reviewed the updates made to #3948 up until the latest commit (7b7b54f). No further issues were found.

Reviewed by:

Graham C

[pullrequest]

Looks to ensure that the right checks are made related to showing the date selector as described in the PR description. I see no issues to moving this forward

James D

---

Reviewed with ❤️ by PullRequest

[literalpie]

Do I understand right that this change removed aria announcements unless you opt in with the new input? Was this change made based on a misunderstanding of this issue? (the correct solution is to add the CSS styles mentioned in that conversation or import the css styles mentioned in the readme)

If the CSS class is causing too much difficulty, maybe inline styles for the aria live announcement would be a better approach? (I can make a PR for that if people think it makes sense)