Merge pull request #1351 from manubo/add-type-to-close-button

Set type attribute of the clear button to "button"
Hacker0x01 · Apr 9, 2018 · 83cf74f · 83cf74f
2 parents 3b1efbe + f86a8e4
commit 83cf74f
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 0 deletions.
diff --git a/src/index.jsx b/src/index.jsx
@@ -605,6 +605,7 @@ export default class DatePicker extends React.Component {
     if (this.props.isClearable && this.props.selected != null) {
       return (
         <button
+          type="button"
           className="react-datepicker__close-icon"
           onClick={this.onClearClick}
           title={this.props.clearButtonTitle}

diff --git a/test/datepicker_test.js b/test/datepicker_test.js
@@ -303,6 +303,17 @@ describe("DatePicker", () => {
     );
   });
 
+  it("should set the type attribute on the clear button to button", () => {
+    var datePicker = TestUtils.renderIntoDocument(
+      <DatePicker selected={utils.newDate("2015-12-15")} isClearable />
+    );
+    var clearButton = TestUtils.findRenderedDOMComponentWithClass(
+      datePicker,
+      "react-datepicker__close-icon"
+    );
+    expect(clearButton.type).to.equal("button");
+  });
+
   it("should allow clearing the date when isClearable is true", () => {
     var cleared = false;
     function handleChange(d) {