Group plans reorder tasks #8358
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paglias
reviewed
Jan 4, 2017
| let order = group.tasksOrder[`${task.type}s`]; | ||
| let currentIndex = order.indexOf(task._id); | ||
|
|
||
| // If for some reason the task isn't ordered (should never happen), push it in the new position |
There was a problem hiding this comment.
is it possible to abstract this logic so that we don't duplicate code between group and user (and maybe challenges) tasks reordering?
paglias
suggested changes
Jan 4, 2017
| let taskId = req.params.taskId; | ||
| let task = await Tasks.Task.findOne({ | ||
| _id: taskId, | ||
| }); |
|
Challenge task reordering is much desired.
…On Wed, 4 Jan 2017, 15:08 Matteo Pagliazzi ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In website/server/controllers/api-v3/tasks/groups.js
<#8358 (review)>
:
> +
+ if (!task) {
+ throw new NotFound(res.t('taskNotFound'));
+ }
+
+ if (task.type === 'todo' && task.completed) throw new BadRequest(res.t('cantMoveCompletedTodo'));
+
+ let group = await Group.getGroup({user, groupId: task.group.id, fields: requiredGroupFields});
+ if (!group) throw new NotFound(res.t('groupNotFound'));
+
+ if (group.leader !== user._id) throw new NotAuthorized(res.t('onlyGroupLeaderCanEditTasks'));
+
+ let order = group.tasksOrder[`${task.type}s`];
+ let currentIndex = order.indexOf(task._id);
+
+ // If for some reason the task isn't ordered (should never happen), push it in the new position
is it possible to abstract this logic so that we don't duplicate code
between group and user (and maybe challenges) tasks reordering?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#8358 (review)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABbTATRnM4Kujuj_U1OHA3_e3CAtCwooks5rO7W9gaJpZM4LZMVq>
.
|
TheHollidayInn
force-pushed
the
group-plans-reorder-tasks
branch
from
1b5509c to
89e85ad
Compare
|
Updated. |
|
Looks good 👍 a unit test for the move task would be perfect but feel free to merge it without |
phillipthelen
pushed a commit
to phillipthelen/habitrpg
that referenced
this pull request
Jan 25, 2017
* Added move route for group tasks * Added group task reorder to front end * Added syncing with group task order * Fixed linting issues * Added missing exec and abstracted move code * Added unit test for moveTask
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes put_issue_url_here
Changes
UUID: