Added quest reject route and intial tests #6640
Conversation
| @@ -18,6 +18,7 @@ import * as firebase from '../../libs/api-v3/firebase'; | |||
| import { sendTxn as sendTxnEmail } from '../../libs/api-v3/email'; | |||
| import { encrypt } from '../../libs/api-v3/encryption'; | |||
| import { quests as questScrolls } from '../../../../common/script/content'; | |||
| import { mockAnalyticsService } from '../../libs/api-v3/analyticsService'; | |||
There was a problem hiding this comment.
Why are we importing a mockAnalyticsService?
There was a problem hiding this comment.
That comments said to use this in a non production environment. I was thinking that that this was replaced somehow in production. Maybe I just misread that.
TheHollidayInn
force-pushed
the
api-v3-quests-reject
branch
from
869416c to
06c88b1
Compare
|
Okay, updated! And, I fixed the merge conflict. Just waiting on Travis, as usual. |
TheHollidayInn
force-pushed
the
api-v3-quests-reject
branch
from
06c88b1 to
3e1fad0
Compare
|
Looks good 👍 Waiting for startQuest |
| * | ||
| * @apiSuccess {Object} Quest Object | ||
| */ | ||
| api.inviteToQuest = { |
There was a problem hiding this comment.
This route was moved to a separate quests.js file. You should remove these lines and add your reject route to it.
There was a problem hiding this comment.
Awesome, can do.
|
Aside from my two remaining comments, I think this looks good. |
TheHollidayInn
force-pushed
the
api-v3-quests-reject
branch
from
3e1fad0 to
eb1e8ce
Compare
|
|
||
| let group = await Group.getGroup({user, groupId: req.params.groupId, fields: 'type quest'}); | ||
| if (!group) throw new NotFound(res.t('groupNotFound')); | ||
| if (!quest) throw new NotFound(res.t('questNotFound', { key: questKey })); |
There was a problem hiding this comment.
Isn't it already validated in the invite route?
There was a problem hiding this comment.
Sure. I was thinking there was some added security with this, but I don't really see that being the case. I think it is good to remove. Sound good to you?
There was a problem hiding this comment.
Yes. Please remove it. If the party quest object is being modified with an invalid key, we have bigger problems and I'd prefer it to blow up so we can track it down.
…tests, and fixed analytics import
TheHollidayInn
force-pushed
the
api-v3-quests-reject
branch
from
eb1e8ce to
442a654
Compare
|
Updated! |
| group.markModified('quest.members'); | ||
|
|
||
| user.party.quest.RSVPNeeded = false; | ||
| user.party.quest.key = null; |
There was a problem hiding this comment.
question: here we should use Group.cleanQuestProgress?
|
Merging manually |
|
updated version at #6693 |
This is the initial quest reject code for #6509 .