Challenge leave route and tests #6591
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| }); | ||
|
|
||
| let tasks = await leavingUser.get('/tasks/user'); | ||
| let testTask = _.find(tasks, (task) => { |
There was a problem hiding this comment.
here would you mind to check that task.challenge has been set to an empty object? (it's possible the api doesn't return task.challenge at all if it's an empty object but it's okay, in that case just test that task.challenge doesn't exist)
There was a problem hiding this comment.
I'm stupid sorry :) I had to scroll down a little more and would have seen that you already tested it :)
|
@paglias updated, leave route now returns empty object on success. |
paglias
added a commit
that referenced
this pull request
Jan 27, 2016
Challenge leave route and tests
|
@KristianTashkov level 4 awarded :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Challenge leave route for #6509
As with join I opted with testing that the main functionalities of
unlinkChallengeTasksare called, and the more detailed ones with be left for unit tests.