Added initial get group tests #6563
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Okay, I just pushed a fix for a failing chat tests, because in this PR I removed the ability to view flags for a non-admin. I am going to work on converting the chat tests to await/async and adding the remaining tests after this, so I didn't make too many adjustments to the chat in this PR. |
| @@ -152,6 +152,13 @@ api.getGroup = { | |||
| let group = await Group.getGroup({user, groupId: req.params.groupId, populateLeader: true}); | |||
| if (!group) throw new NotFound(res.t('groupNotFound')); | |||
|
|
|||
| if (!user.contributor.admin) { | |||
| _.remove(group.chat, function removeChat (chat) { | |||
There was a problem hiding this comment.
@TheHollidayInn here you probably want to convert the group to a plain object with group.toJSON before removing flags information
There was a problem hiding this comment.
What will that help with?
TheHollidayInn
force-pushed
the
api-v3-get-group-tests
branch
from
6a58ab5 to
2063070
Compare
|
Updated! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most of the get group tests from V2 transferred. I removed some member tests, cleaned up some others, and added the new generating chat functions.
This is part of #6509.