Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing value of rewards deducted the amount from my gold and then killed me. #388

Closed
cleave29 opened this issue Feb 13, 2013 · 21 comments
Closed

Comments

@cleave29
Copy link
Contributor

I changed the value of a reward and it deducted the amount from my gold each time I pressed the cost down button. Then I died.

@Pandoro
Copy link

Pandoro commented Feb 13, 2013

So you clicked the number specifying the number you put in there?

On Wed, Feb 13, 2013 at 8:49 PM, cleave29 [email protected] wrote:

I changed the value of a reward and it deducted the amount from my gold
each time I pressed the cost down button. Then I died.


Reply to this email directly or view it on GitHubhttps://github.com//issues/388.

@cleave29
Copy link
Contributor Author

Not the cost button, but the "decrease" button for the cost in the edit
menu.
(I almost killed myself pressing the cost button and then I killed myself
trying to change the cost with the down arrow.)
Matt

On Wed, Feb 13, 2013 at 11:54 AM, Pandoro [email protected] wrote:

So you clicked the number specifying the number you put in there?

On Wed, Feb 13, 2013 at 8:49 PM, cleave29 [email protected]
wrote:

I changed the value of a reward and it deducted the amount from my gold
each time I pressed the cost down button. Then I died.


Reply to this email directly or view it on GitHub<
https://github.com/lefnire/habitrpg/issues/388>.


Reply to this email directly or view it on GitHubhttps://github.com//issues/388#issuecomment-13514489.

@Pandoro
Copy link

Pandoro commented Feb 13, 2013

Hmmm I must be honest here, I cannot follow you :x I do not have a "decrease button". Could you maybe post a screenshot of the button you mean?

Otherwise ... @SlappyBag ? You know what is meant here :x ?

@cleave29
Copy link
Contributor Author

Sorry I'm not making myself clear. By "decrease button", I mean the down
arrow near "Price" in the edit screen of the reward.
I'll attach a screen shot. Did it go through?
Thanks for responding,
Matt

On Wed, Feb 13, 2013 at 1:57 PM, Pandoro [email protected] wrote:

Hmmm I must be honest here, I cannot follow you :x I do not have a
"decrease button". Could you maybe post a screenshot of the button you mean?

Otherwise ... @SlappyBag https://github.com/SlappyBag ? You know what
is meant here :x ?


Reply to this email directly or view it on GitHubhttps://github.com//issues/388#issuecomment-13520638.

@StanLindsey
Copy link
Contributor

Yeah I didn't know what you meant at first but there is a number increment input box when you edit/create a reward. I couldn't replicate the bug you've been having though.

@Pandoro
Copy link

Pandoro commented Feb 13, 2013

Screenshot from 2013-02-13 23:12:15

This is all I can see when I edit a reward :o

@cleave29
Copy link
Contributor Author

Huh.
OK, well, thanks for looking at it.
If it happens again, I'll let you know.
Matt

On Wed, Feb 13, 2013 at 2:12 PM, Stan Lindsey [email protected]:

Yeah I didn't know what you meant at first but there is a number increment
input box when you edit/create a reward. I couldn't replicate the bug
you've been having though.


Reply to this email directly or view it on GitHubhttps://github.com//issues/388#issuecomment-13521420.

@lefnire
Copy link
Contributor

lefnire commented Feb 13, 2013

It's a browser thing. Safari handles <input type="number"> like this, for example. So you're saying you clicked that down-arrow and lost HP? I can't replicate

@cleave29
Copy link
Contributor Author

Just out of curiosity, what if you spend more gold than you have thus losing hit points, then press the down arrow?

@Pandoro
Copy link

Pandoro commented Feb 18, 2013

@cleave29 has this occurred again? Apparently nobody could recreate the bug. Which does not mean it wasn't there, but it will make it hard to find if we don't know what it looks like :x

@cleave29
Copy link
Contributor Author

No, luckily, it hasn't.
I've been really careful about using rewards since then, so I don't really want to go looking for it.
Have you tried the suggestion above: "Just out of curiosity, what if you spend more gold than you have thus losing hit points, then press the down arrow?" If so, then I guess it's gone.
Thanks for looking into it.

@Pandoro
Copy link

Pandoro commented Feb 18, 2013

Well I would try it on the test server, but as I mentioned, I was never
able to find the down button in my browser. But from what I understand from
@lefnire s comment, he wasn't able to reproduce it.

Maybe you can test this on the test server? http://habitrpg.herokuapp.com/
There you can play around a little, you don't even need to log in for that.
You should be able to buy some rewards so that they start eating away at
your habits. In your browser you should see the down button and try to
press it when it comes to this. I guess if you cannot reproduce it there,
it might have been fixed in one of the recent updates. Otherwise we have a
starting point to debug it :)

On Mon, Feb 18, 2013 at 9:01 PM, cleave29 [email protected] wrote:

No, luckily, it hasn't.

I've been really careful about using rewards since then, so I don't really
want to go looking for it.

Have you tried the suggestion above: "Just out of curiosity, what if you
spend more gold than you have thus losing hit points, then press the down
arrow?" If so, then I guess it's gone.
Thanks for looking into it.


Reply to this email directly or view it on GitHubhttps://github.com//issues/388#issuecomment-13740003.

@cleave29
Copy link
Contributor Author

I can't replicate it on the test server, but, er... There are several of my bugs that do not happen on the test server. For example, I can - Oh, wait, y'all fixed the drag function. Sweet...
For example, I tried to replicate the "having-my-health-restored-and-gaining-20g-with-a-Habit-after-using-an-undeserved-reward" on the test server and it didn't work. But it happened to me on my profile this afternoon. So, is there a difference between the test server and my profile?

@Pandoro
Copy link

Pandoro commented Feb 19, 2013

Hmm I must admit I am not a 100% sure which version the test server is
running right now. But knowing that it does not occur on there might help
finding out the cause of this problem.

What do you mean by the other bug you mentioned :x ?

On Tue, Feb 19, 2013 at 4:31 AM, cleave29 [email protected] wrote:

I can't replicate it on the test server, but, er... There are several of
my bugs that do not happen on the test server. For example, I can - Oh,
wait, y'all fixed the drag function. Sweet...
For example, I tried to replicate the
"having-my-health-restored-and-gaining-20g-with-a-Habit-after-using-an-undeserved-reward"
on the test server and it didn't work. But it happened to me on my profile
this afternoon. So, is there a difference between the test server and my
profile?


Reply to this email directly or view it on GitHubhttps://github.com//issues/388#issuecomment-13755209.

@lefnire
Copy link
Contributor

lefnire commented Feb 19, 2013

Test server is old, I'll take it down. We haven't set up a CI deploy of
develop yet

On Tue, Feb 19, 2013 at 5:19 AM, Pandoro [email protected] wrote:

Hmm I must admit I am not a 100% sure which version the test server is
running right now. But knowing that it does not occur on there might help
finding out the cause of this problem.

What do you mean by the other bug you mentioned :x ?

On Tue, Feb 19, 2013 at 4:31 AM, cleave29 [email protected]
wrote:

I can't replicate it on the test server, but, er... There are several of
my bugs that do not happen on the test server. For example, I can - Oh,
wait, y'all fixed the drag function. Sweet...
For example, I tried to replicate the

"having-my-health-restored-and-gaining-20g-with-a-Habit-after-using-an-undeserved-reward"

on the test server and it didn't work. But it happened to me on my
profile
this afternoon. So, is there a difference between the test server and my
profile?


Reply to this email directly or view it on GitHub<
https://github.com/lefnire/habitrpg/issues/388#issuecomment-13755209>.


Reply to this email directly or view it on GitHubhttps://github.com//issues/388#issuecomment-13765622.

@cleave29
Copy link
Contributor Author

@Pandoro I mean #417

@Pandoro
Copy link

Pandoro commented Feb 19, 2013

@cleave29 sorry for the ... bad help. I wasn't aware the test server was so old :( But @lefnire this might still be interesting? That both this and #417 did not occur on that version of the code? Do you know which version was running there?

@cleave29
Copy link
Contributor Author

@Pandoro No sweat

@lefnire
Copy link
Contributor

lefnire commented Feb 20, 2013

ok, #417 is closed now. how we doing on this ticket?

@horusofoz
Copy link

Closing as no response from user after a week

@cleave29
Copy link
Contributor Author

Oh, sorry, the down arrow doesn't seem to damage me anymore, so I think we're good. Thanks! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants