-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Add HPU support to vLLM v1 #487
base: habana_main
Are you sure you want to change the base?
Conversation
tests/distributed/test_utils.py
Outdated
def test_stateless_process_group(worker): | ||
port1 = get_open_port() | ||
with socket.socket(socket.AF_INET, socket.SOCK_STREAM) as s: | ||
s.bind(("", port1)) |
Check warning
Code scanning / CodeQL
Binding a socket to all network interfaces Medium test
Show autofix suggestion
Hide autofix suggestion
Copilot Autofix AI 2 days ago
To fix the problem, we need to bind the socket to a specific interface instead of all interfaces. In this case, we can bind the socket to the loopback interface (127.0.0.1
), which is commonly used for local testing and does not expose the service to external networks.
- Change the binding address from
''
to'127.0.0.1'
on line 127. - This change ensures that the socket only accepts connections from the local machine, mitigating the security risk.
-
Copy modified line R127
@@ -126,3 +126,3 @@ | ||
with socket.socket(socket.AF_INET, socket.SOCK_STREAM) as s: | ||
s.bind(("", port1)) | ||
s.bind(("127.0.0.1", port1)) | ||
port2 = get_open_port() |
Early prototype. Lots of basic stuff is completely broken.