Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/target option #47

Merged
merged 11 commits into from
Oct 3, 2023
Merged

Feat/target option #47

merged 11 commits into from
Oct 3, 2023

Conversation

alexravenna
Copy link
Contributor

@alexravenna alexravenna commented Sep 15, 2023

Summary

The option target, denoting the target architectures the extension can be used on, was added to the Action, since both vsce and osvx now support it.

Changes

  • optional target option added to the Action

Related Issues

Implements #37

@alexravenna
Copy link
Contributor Author

alexravenna commented Sep 15, 2023

Hey @HaaLeo, thanks for this extension! I'm already using it to publish my theme and am happy to help make VS Code extensions available on more platforms!

I looked at the sources from osvx and implemented this according to how I understood those, since it seems like osvx handles target differently from vsce...but I'm not 100% certain if I got it all right 😅. Is there any way to test the extension in this "development" state? Or should I just test it on the command line with the --target parameter?

@HaaLeo
Copy link
Owner

HaaLeo commented Sep 18, 2023

Hi @alexravenna, thx for your contribution. It is somewhat tricky to test this GH action. But you can reference your repo/branch instead of HaaLeo/publish-vscode-extension@v1. I've done that before with a hello-world VS Code extension.

I'll hope to be able to review your PR throughout this week. But I cannot promise 😅

@HaaLeo HaaLeo merged commit d60feeb into HaaLeo:master Oct 3, 2023
5 checks passed
@alexravenna alexravenna deleted the feat/target-option branch October 3, 2023 18:46
@drok
Copy link

drok commented Feb 15, 2024

This doesn't quite work. With the following snippet (note the dry-run), the generated visx does not include TargetPlatform="linux-x64" as expected

     - name: Package Extension
       id: packageExtension
       uses: HaaLeo/publish-vscode-extension@v1
       with:
         pat: stub
         preRelease: true
         dryRun: true
         yarn: true
         target: ${{ matrix.config.name }}

A quick look at the commits in this PR shows that the --target option is applied to the publishing step, which makes some sense.

However, since the action also supports dryRun (pack only), that mode should not generate a defective visx.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants