-
-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/target option #47
Conversation
Hey @HaaLeo, thanks for this extension! I'm already using it to publish my theme and am happy to help make VS Code extensions available on more platforms! I looked at the sources from |
Hi @alexravenna, thx for your contribution. It is somewhat tricky to test this GH action. But you can reference your repo/branch instead of I'll hope to be able to review your PR throughout this week. But I cannot promise 😅 |
This doesn't quite work. With the following snippet (note the - name: Package Extension
id: packageExtension
uses: HaaLeo/publish-vscode-extension@v1
with:
pat: stub
preRelease: true
dryRun: true
yarn: true
target: ${{ matrix.config.name }} A quick look at the commits in this PR shows that the However, since the action also supports dryRun (pack only), that mode should not generate a defective visx. |
Summary
The option
target
, denoting the target architectures the extension can be used on, was added to the Action, since bothvsce
andosvx
now support it.Changes
target
option added to the ActionRelated Issues
Implements #37