Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Internationalization, Accessibility and HTML syntax quick fixes #1

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

fititnt
Copy link

@fititnt fititnt commented Apr 14, 2020

Hello HXL team. I loved how simple this repository uses to generate the HTML page! Here some quick fixes I found, and their references.

I will keep this PR simple.

Comparison

List of changes

Refs covid-taskforce-cplp/dados-covid#17

- Added lang="en" (see https://www.w3.org/International/questions/qa-lang-why)
- meta charset before any text, in this case <title> (fix issues with non-ascii programs that may render wrong, as they may default to non-utf8 before find the charset tag); also see https://www.w3.org/International/questions/qa-html-encoding-declarations
- <script> tag on body;
- The ; on &nbsp fix "Error: Named character reference was not terminated by a semicolon. (Or & should have been escaped as &amp;.)"
- Documentation now cites the gen-chooser.py when not using make

Refs covid-taskforce-cplp/dados-covid#17
fititnt added a commit to HXL-CPLP/assistente-hashtags-hxl that referenced this pull request Apr 24, 2020
…uick fixes 1' de

HXLStandard/hxl-hashtag-chooser#1 . Comandos usados:

$ curl https://patch-diff.githubusercontent.com/raw/HXLStandard/hxl-hashtag-chooser/pull/1.patch --silent --output HXLStandard_hxl-hashtag-chooser_pull_1.patch
$ git apply HXLStandard_hxl-hashtag-chooser_pull_1.patch
$ rm git apply HXLStandard_hxl-hashtag-chooser_pull_1.patch
$ git add .
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant