-
-
Notifications
You must be signed in to change notification settings - Fork 183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SEO 2024 queries #3791
Merged
Merged
SEO 2024 queries #3791
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tunetheweb
changed the title
Add finalized SQL files with is_root_page element for improved efficiency
SEO 2024 queries
Oct 14, 2024
This was referenced Oct 30, 2024
tunetheweb
reviewed
Oct 30, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall LGTM with a couple of small comments.
Let me know when good to merge.
Co-authored-by: Barry Pollard <[email protected]>
Co-authored-by: Barry Pollard <[email protected]>
tunetheweb
reviewed
Nov 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes progress on #3600
This PR adds the finalized SQL files which now include an is_root_page element that differentiates between the homepage and secondary pages. All SQL files utilize the June dataset, as it was the originating dataset used during the construction of these queries.
Context:
These changes were made to finalize the SQL queries for the 2024 SEO analysis. The new is_root_page element improves data separation between homepages and other pages, enhancing the overall analysis accuracy. Additionally, minor updates were applied to the SQL queries from 2022 to align with the new dataset structure. Common Table Expressions (CTEs) were introduced to improve efficiency and query readability.
Changes Made: