-
-
Notifications
You must be signed in to change notification settings - Fork 183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Page Weight 2021 Contributors #2493
Conversation
@rviscomi Few things to mop up. I may need some help on formatting 2021 figures. I'm so tired right now I can't think clearly. But nearly done.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I removed extra spaces caused, I think from a copy and paste from StackEdit to MS Code to GitHub file. Think it's good to run another merge and check linter errors again.
Fixed the markup and staged it here: https://20211115t201245-dot-webalmanac.uk.r.appspot.com/en/2021/page-weight. We can update that content as more gets written (note this is manual and so won't happen automatically). I also added the link to the first comment. |
I have fixed the figure descriptions and added just a conclusion to speed completion. But I believe this is ready for review and will make the mid week deadline I set.
@rviscomi I am not sure what needs to be done to clear the conflict. I don't know how to merge this to staging. Any help would be appreciated with that. I edited this directly in GitHub this time. Thank you. |
@logicalphase the intent of this PR was just to get the contributors in, to avoid the merge conflicts while we work on the chapter. So I've pulled out all your chapter and will open a separate PR for that after merging this. |
Okay. Thanks Barry. I appreciate your help. |
"RMHolmlund": { | ||
"name": "RMHolmlund", | ||
"teams": [ | ||
"editors" | ||
], | ||
"avatar_url": "https://avatars.githubusercontent.com/u/61608378?v=4&s=200", | ||
"github": "RMHolmlund" | ||
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@RMHolmlund do you want your full name credited in the chapter? Also let us know if there are any other platforms you'd like promoted (Twitter, LinkedIn, or personal website)
Progress on #2157
Staged URL: