Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Media 2021 contributors #2486

Merged
merged 4 commits into from
Nov 16, 2021
Merged

Update Media 2021 contributors #2486

merged 4 commits into from
Nov 16, 2021

Conversation

rviscomi
Copy link
Member

Progress on #2144

@rviscomi rviscomi added writing Related to wording and content project management Keeping the ball rolling labels Nov 14, 2021
@rviscomi rviscomi added this to the 2021 Launch 🚀 milestone Nov 14, 2021
@rviscomi rviscomi requested a review from eeeps November 14, 2021 22:07
tunetheweb
tunetheweb approved these changes Nov 16, 2021
View reviewed changes
Copy link
Member

@tunetheweb tunetheweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved. Suspect this will fail again since we now no longer generate chapters when TODO is set to false, so Lighthouse tests cannot run.

Ignore any Lighthouse error and merge.

@rviscomi rviscomi merged commit 5e8479e into main Nov 16, 2021
@rviscomi rviscomi deleted the media-contributors branch November 16, 2021 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tunetheweb tunetheweb tunetheweb approved these changes

@eeeps eeeps Awaiting requested review from eeeps

Assignees

@eeeps eeeps

Labels
project management Keeping the ball rolling writing Related to wording and content
Projects
None yet
Milestone
2021 Launch 🚀
Development

Successfully merging this pull request may close these issues.
3 participants
@rviscomi @tunetheweb @eeeps