Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Traditional Chinese Translation-templates #1418

Merged
merged 12 commits into from
Nov 7, 2020

Conversation

AbbyTsai
Copy link
Contributor

@AbbyTsai AbbyTsai commented Nov 5, 2020

Translate content of templates into Traditional Chinese #1106

2019

  • base.html
  • base_chapter.html
  • base_ebook.html
  • contributors.html
  • error.html
  • index.html
  • table_of_contents.html

2020

  • base.html
  • index.html
  • contributors.html

Copy link
Member

@tunetheweb tunetheweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @AbbyTsai ! Few comments - with the held of Google Translate - feel free to correct to real Chinese :-)

src/templates/zh-CHT/base.html Outdated Show resolved Hide resolved
src/templates/zh-CHT/base.html Outdated Show resolved Hide resolved
src/templates/zh-CHT/base.html Outdated Show resolved Hide resolved
src/templates/zh-CHT/base.html Outdated Show resolved Hide resolved
@tunetheweb tunetheweb added the translation world wide web label Nov 6, 2020
@tunetheweb tunetheweb added this to the 2019 Backlog milestone Nov 6, 2020
@AbbyTsai AbbyTsai changed the title Traditional Chinese Translation-2019 templates Traditional Chinese Translation-templates Nov 6, 2020
@tunetheweb
Copy link
Member

tunetheweb commented Nov 6, 2020

@AbbyTsai could you do a fews things for me to solve all the test errors:

  • Merge upstream main into this branch to pick up latest changes
  • Add zh-CHT to to line 37 or so of src/server/language.py
  • Add zh-CHT to line 5 src/config/2019.json
  • Add zh-CHT to line 5 src/config/2020.json

Then commit all those changes and it should sort all your errors out.

Copy link
Member

@tunetheweb tunetheweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One typo.

You also need the src/templates/zh-CHT/2020/base.html file for the site to work. This is quite small so should be easy to translate.

@@ -34,7 +34,7 @@ class Language(object):
JA = _Language('日本語', 'ja')
PT = _Language('Português', 'pt')
ZH_CN = _Language('简体中文', 'zh-CN')

ZH_CHT=_Language('繁體中文', 'zh-CHT')
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missed a space here:

Suggested change
ZH_CHT=_Language('繁體中文', 'zh-CHT')
ZH_CHT= _Language('繁體中文', 'zh-CHT')

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

revised it.

src/server/language.py Show resolved Hide resolved
src/templates/zh-CHT/2020/base.html Outdated Show resolved Hide resolved
@tunetheweb tunetheweb merged commit 496df88 into HTTPArchive:main Nov 7, 2020
@tunetheweb
Copy link
Member

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
translation world wide web
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants