Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chapter numbers missing from chapter footer navigation #2209

Closed
rviscomi opened this issue May 25, 2021 · 2 comments · Fixed by #2215
Closed

Chapter numbers missing from chapter footer navigation #2209

rviscomi opened this issue May 25, 2021 · 2 comments · Fixed by #2215
Assignees
@LucasBona05
Labels
bug Something isn't working development Building the Almanac tech stack good first issue Good for newcomers
Milestone
Backlog

Comments

@rviscomi
Copy link
Member

rviscomi commented May 25, 2021 •
edited
Loading

image

https://almanac.httparchive.org/en/2020/cms#authors

Expected: "Chapter 16 / Ecommerce"
Actual: "Chapter / Ecommerce"
@rviscomi rviscomi added bug Something isn't working good first issue Good for newcomers development Building the Almanac tech stack labels May 25, 2021
@rviscomi rviscomi added this to the 2020 Backlog milestone May 25, 2021
@LucasBona05 LucasBona05 mentioned this issue May 26, 2021
Closed
@LucasBona05
Copy link
Contributor

I'm interested in contribute on that issue! May I have it?

@tunetheweb
Copy link
Member

tunetheweb commented May 26, 2021 •
edited
Loading

Assigned - go for it!

LucasBona05 added a commit to LucasBona05/almanac.httparchive.org that referenced this issue May 30, 2021
@LucasBona05
Add chapter number to the chapter footer navigation (HTTPArchive#2209)
6c44517
@tunetheweb tunetheweb mentioned this issue May 31, 2021
Closed
LucasBona05 added a commit to LucasBona05/almanac.httparchive.org that referenced this issue May 31, 2021
@LucasBona05
Revert "Add chapter number to the chapter footer navigation (HTTPArch…
91252f2 
…ive#2209)"

This reverts commit 6c44517.
LucasBona05 added a commit to LucasBona05/almanac.httparchive.org that referenced this issue May 31, 2021
@LucasBona05
Add chapter number to the chapter footer navigation (HTTPArchive#2209)
70d59e0
@tunetheweb tunetheweb mentioned this issue May 31, 2021
Merged
tunetheweb pushed a commit that referenced this issue May 31, 2021
@LucasBona05
Fixes #2209 (#2215)
c20b8df 
* Add chapter number to the chapter footer navigation (#2209)

* Revert "Add chapter number to the chapter footer navigation (#2209)"

This reverts commit 6c44517.

* Add chapter number to the chapter footer navigation (#2209)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@LucasBona05 LucasBona05

Labels
bug Something isn't working development Building the Almanac tech stack good first issue Good for newcomers
Projects
None yet
Milestone
Backlog
3 participants
@rviscomi @tunetheweb @LucasBona05